Fix navbar-burger color when color modifier is used #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgthms
requested changes
Jul 9, 2018
sass/components/navbar.sass
Outdated
| @@ -74,6 +74,8 @@ $navbar-bottom-box-shadow-size: 0 -2px 0 0 !default | |||
| .navbar-link | |||
| &::after | |||
| border-color: $color-invert | |||
| & > .navbar-burger | |||
There was a problem hiding this comment.
You don't really need the nesting here. Just use .navbar-burger.
There was a problem hiding this comment.
OK, I changed it. Is it that what you meant?
There was a problem hiding this comment.
Not exactly. Put .navbar-burger as a sibling of .navbar-brand, not as a child of .navbar-brand.
There was a problem hiding this comment.
Ah, I see: .navbar-burger does not necessarily need to be a child of .navbar-brand. Makes sense. So, here my next try. Is that correct? Thank's for your patience.
When using a color modifier for a navbar (e.g., is-dark) the burger icon does not change the color. This commit adds the color modification for the navbar burger icon.
|
Just want to ask whether it is ready to merge after the latest correction to include it in the next release!? Is there anything I can do to help? Thanks for considering … |
jgthms
approved these changes
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a color modifier for a navbar (e.g., is-dark) the burger icon does not change the color. This commit adds the color modification for the navbar burger icon.
This is a bugfix.
Issue #1981.
Proposed solution
This solution adds color-invert for the .navbar-burger for the color modifiers the same way it is done for .navbar-link.
Tradeoffs
No tradeoffs.
Testing Done
I checkout out master and changed the lines. The color of the burger icon is as desired. You can see a minimal example I used there: https://jsfiddle.net/pm26zwer/6/
See also issue #1981.