Fixes #2741: Update form inputs derived variables #2743
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
$grey-darker
and$grey
as default instead of$text-strong
and$text-light
which may contain the "inherit" value (fixes issue #2741)This is an improvement / bugfix.
I ran into a compiling error with Bulma 0.8.0 when trying to use
inherit
value for the$text-strong
variable. I found out this is due to breaking changes in commit 0f988ea in which a lot of default colors have been modified. This particular line was throwing the error when usinginherit
value for$text-strong
:I think we may often use this particular value for the
$text-strong
and$text-light
variables because there are a lot of cases where a<strong>
tag in a text should just inherit its parent color.Also I think it doesn't really make sense to use the strong text color as default in any other derived variable.
Proposed solution
In this PR I just put back the old default values, replacing
$text-strong
by$grey-darker
and$text-light
by$grey
. By the way this is what the docs actually says.Tradeoffs
There are still other derived variables which use the
$text-strong
and$text-light
ones as default. All of these changes have been made in commit 0f988ea.Maybe it could be a better idea to roll back the whole commit but I'm not really sure about that.
Testing Done
I did test this PR in my project. Using
$text-strong: inherit
does not throw a compiling error anymore.Changelog updated?
No.