Add optgroup to the list of tags that have font-family set #3107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the latest version of Firefox, the `font-family` is respected for `option`s in a `select`, but not for `option`s in an `optgroup` is a `select`. This fixes that.
dangowans
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest version of Firefox (and possibly other browsers), the
font-familyis respected foroptions in aselect, but not foroptions in anoptgroupis aselect. This fixes that.This is a bugfix.
Proposed solution
Add
optgroupto the list of tags that have font-family set.Tradeoffs
None.
Testing Done
In my own project. Note that I'm using the Barlow font in my project.
Before
After
Changelog updated?
No.