Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node-gyp to remove dependency on Python 2 #831

Closed
bitfehler opened this issue Mar 24, 2021 · 1 comment · Fixed by #834
Closed

Update node-gyp to remove dependency on Python 2 #831

bitfehler opened this issue Mar 24, 2021 · 1 comment · Fixed by #834

Comments

@bitfehler
Copy link

Hi there!

First of all, thanks a lot for all this, we are big fans of Yopass! We deploy our own instance and recently ran into problems because we tried to get rid of Python 2 on the underlying system. The issue seems to be that node-gyp is locked to version 3.8.0, which does not yet have support for Python 3 (see nodejs/node-gyp#193).

Python 2 is basically obsolete by now, so getting rid of this dependency would be really great.

Unfortunately I am not very versed with the whole node ecosystem tooling, so providing a PR would take me quite some effort. If someone with more skills on that front could maybe jump in that would be much appreciated. However, if so desired, I can also try my luck at this.

@jhaals
Copy link
Owner

jhaals commented Mar 27, 2021

Hi @bitfehler and thanks for the kind words, really appreciate hearing this!

Glad you pointed this out, it turns out this was part of node-sass which isn't used anymore so I removed it entirely :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants