From df1e70663134a994a6dd1a43a9291eecd4a595c5 Mon Sep 17 00:00:00 2001 From: Vladimir Date: Wed, 14 Sep 2022 19:44:07 +0300 Subject: [PATCH] =?UTF-8?q?=F0=9F=AA=9F=20=F0=9F=94=A7=20Increase=20color?= =?UTF-8?q?=20palette=20consistency:=20=20prohibit=20to=20use=20hex=20valu?= =?UTF-8?q?e=20for=20colors=20(#16662)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- airbyte-webapp/.stylelintrc | 3 ++- airbyte-webapp/public/index.css | 1 + airbyte-webapp/src/components/base/Card/Card.module.scss | 3 ++- .../cloud/views/auth/OAuthLogin/OAuthLogin.module.scss | 1 + airbyte-webapp/src/scss/_colors.scss | 1 + 5 files changed, 7 insertions(+), 2 deletions(-) diff --git a/airbyte-webapp/.stylelintrc b/airbyte-webapp/.stylelintrc index 5332fb7e697d..48cc309879ab 100644 --- a/airbyte-webapp/.stylelintrc +++ b/airbyte-webapp/.stylelintrc @@ -12,7 +12,8 @@ "scss/dollar-variable-empty-line-before": null, "scss/dollar-variable-pattern": null, "scss/percent-placeholder-pattern": null, - "value-keyword-case": null + "value-keyword-case": null, + "color-no-hex": true }, "ignoreFiles": ["**/build/**", "**/dist/**"] } diff --git a/airbyte-webapp/public/index.css b/airbyte-webapp/public/index.css index 480d3fa79b1c..c0a42b64b8a1 100644 --- a/airbyte-webapp/public/index.css +++ b/airbyte-webapp/public/index.css @@ -1,3 +1,4 @@ +/* stylelint-disable color-no-hex */ body, html { margin: 0; height: 100%; diff --git a/airbyte-webapp/src/components/base/Card/Card.module.scss b/airbyte-webapp/src/components/base/Card/Card.module.scss index 50a504028893..319e7b6a39bd 100644 --- a/airbyte-webapp/src/components/base/Card/Card.module.scss +++ b/airbyte-webapp/src/components/base/Card/Card.module.scss @@ -1,4 +1,5 @@ @use "../../../scss/colors"; +@use "../../../scss/variables" as vars; .container { width: auto; @@ -18,7 +19,7 @@ .title { padding: 25px 25px 22px; color: colors.$dark-blue; - border-bottom: #e8e8ed 1px solid; + border-bottom: colors.$grey-100 vars.$border-thin solid; font-weight: 600; letter-spacing: 0.008em; border-top-left-radius: 10px; diff --git a/airbyte-webapp/src/packages/cloud/views/auth/OAuthLogin/OAuthLogin.module.scss b/airbyte-webapp/src/packages/cloud/views/auth/OAuthLogin/OAuthLogin.module.scss index b2d2e733f276..0b693bf1259b 100644 --- a/airbyte-webapp/src/packages/cloud/views/auth/OAuthLogin/OAuthLogin.module.scss +++ b/airbyte-webapp/src/packages/cloud/views/auth/OAuthLogin/OAuthLogin.module.scss @@ -43,6 +43,7 @@ } .github { + /* stylelint-disable-next-line color-no-hex */ background: #333; color: colors.$white; border: none; diff --git a/airbyte-webapp/src/scss/_colors.scss b/airbyte-webapp/src/scss/_colors.scss index a1751d78fca0..3521285415b8 100644 --- a/airbyte-webapp/src/scss/_colors.scss +++ b/airbyte-webapp/src/scss/_colors.scss @@ -1,3 +1,4 @@ +/* stylelint-disable color-no-hex */ $blue-50: #eae9ff; $blue-100: #cbc8ff; $blue-200: #a6a4ff;