-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support NC14 #83
Comments
Mentioned here: #67 (comment) Since there's still active discussion about how mimetype implementation should be fixed (issue was often raised), NC dependency hasn't been updated until a good solution is found for it. |
ok! wait... |
I'm waiting too ! thanks a lot :) |
Can we still open keeweb by clicking a kdbx file like in NC13? That would be enough for me... |
Keeweb was working fine for me in NC13. I had to tell the server to associate kdbx file extentions with the keeweb app and set the app's info.xml to version 13 but it worked fine. I just upgraded from 13 to 14, changed the version again and re-enabled the app. It's stable and everything still works but the body of the page is all pushed off to the left, as if the entire app is being loaded in a nav bar. Any ideas on how I can circumvent this issue? Also, what is keeping keeweb from being updated from 12 to 13 and or 14? Someone's time or something else? Thanks! Edit: Actually this fixed the width problem mentioned above. |
Can you share with us how you did that? |
Follow the instructions in this PR Worked for me in NC14. |
Thank you. I have no issues with NC14 and keeweb :-) If you add a new kbdx file, need to do the scan again :-) |
Here neither. It would really be nice to implement the proposed changes - there are other apps there as well which require manual MIME type additions and I don't think that an API change in Nextcloud to avoid this manual step will come soon. |
Keeweb still works with Nextcloud 15 after adjusting |
i gave @jhass a heads up on how another app solves the problem of registering mimetypes (Epub/Cbz/PDF reader app) over here but sadly it seems @jhass is not interested in it as I got no answer: #67 (comment) |
Can someone create a zip for nc 15? Or is there a recent fork...? |
My fork is at https://github.com/arnowelzel/nextcloud-keeweb. I will add all required changes to make it usable with NC15 too. @jhass what is your official strategy? You won't release a new Keeweb version until NC provides a working API for MIME type registration? In this case I'll fork it and offer it as "Keeweb2". Because I think it is way better to have an app which is a bit cumbersome to install than not having anything at all. And Keepass is the de facto standard for password safes and should be promoted wherever possible. Also see Keepass2Android - this supports Nextcloud as storage with an offline cache on the device. |
Recently, there is a lot of good apps for keepass databases. |
It seems we are finally getting somewhere. See the comments at #81. Thank you :-). |
@arnowelzel do you have a succesful build to share with us? |
@ravermeister You can always downgrade nodejs if needed, see here for example: https://www.abeautifulsite.net/how-to-upgrade-or-downgrade-nodejs-using-npm But I'll provide a build as soon as possible. |
Thanks for the hint, with this version:
audited 1 package in 0.627s npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.7 (node_modules/fsevents): audited 12497 packages in 15.803s bower ENOENT No bower.json present ...the App installs and is shown, but when I want to access it I get an "Internal Server Error" on the menu Frame and the content is a blank page... Update: this is my ...I give up, still blank page.. |
To create a version which can just be copied to an existing Nextcloud instance, you only need to run However - I was not lucky as well so far - same problem here even after applying b6584d0 - sorry :-( |
Ok, it there is a file missing after the build. See #16 - I have to sort out, how the build is done properly. |
Well - I did not figure out, how to get the build properly done. The missing file is copied from So - I used You can download a working archive here: https://nextcloud.0x0c.de/s/tcEzYLB5gb8AJEY Extract the archive to the |
the dist folder is in keeweb-source and there is a index.html too, |
Indeed - Keeweb 1.7.4 seems not to work at all. There is also a minor glitch with the CSP, but this only causes a warning in the console, I fixed this with arnowelzel@02d0519. But this does not change anything, Keeweb 1.7.4 still does not start and there is no error at all in the console to indicate what's going on. |
JFTR: I also updated https://nextcloud.0x0c.de/s/tcEzYLB5gb8AJEY with the fixed CSP. |
Thanks, even Version 1.6.x does not work, I'll try with 1.5.x and tell if I was successful |
I think, this is related to the change introduced here: nextcloud/server@5b61ef9#diff-ea7fde28f6b4be25c841ed420fef5cdf Also see #81 (comment) which mentions this. |
Yes I merged b6584d0 Into my fork but no luck, I get some errors during build which are ignored due to - - force flag. I'll keep trying to build 🙂 anyway your zip works 👍 |
Try 0.5.0. Never tested it for NC14 but it should still work. Or just jump to NC15 :) Take care of the required manual steps as outlined in the readme! |
It works great on my installation. Loving it! Thanks for all the work! :D ❤️ |
Since a few days (week?) nextcloud 14 is in RC state.
any plans on this support?
The text was updated successfully, but these errors were encountered: