Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NC14 #83

Closed
Heidistein opened this issue Sep 4, 2018 · 29 comments
Closed

Support NC14 #83

Heidistein opened this issue Sep 4, 2018 · 29 comments

Comments

@Heidistein
Copy link

Since a few days (week?) nextcloud 14 is in RC state.
any plans on this support?

@TheTimeWalker
Copy link

Mentioned here: #67 (comment)

Since there's still active discussion about how mimetype implementation should be fixed (issue was often raised), NC dependency hasn't been updated until a good solution is found for it.

@twixi
Copy link

twixi commented Sep 24, 2018

ok! wait...

@ThisIsMe-TIM
Copy link

I'm waiting too ! thanks a lot :)

@jpereztenerife
Copy link

Can we still open keeweb by clicking a kdbx file like in NC13? That would be enough for me...

@k1rb
Copy link

k1rb commented Oct 15, 2018

Keeweb was working fine for me in NC13. I had to tell the server to associate kdbx file extentions with the keeweb app and set the app's info.xml to version 13 but it worked fine. I just upgraded from 13 to 14, changed the version again and re-enabled the app. It's stable and everything still works but the body of the page is all pushed off to the left, as if the entire app is being loaded in a nav bar.

Any ideas on how I can circumvent this issue? Also, what is keeping keeweb from being updated from 12 to 13 and or 14? Someone's time or something else?

Thanks!

Edit: Actually this fixed the width problem mentioned above.

@zoh48gz04
Copy link

I had to tell the server to associate kdbx file extentions with the keeweb app

Can you share with us how you did that?

@unomar
Copy link

unomar commented Oct 16, 2018

I had to tell the server to associate kdbx file extentions with the keeweb app

Can you share with us how you did that?

Follow the instructions in this PR
https://github.com/jhass/nextcloud-keeweb/pull/81/files

Worked for me in NC14.

@edzoe
Copy link

edzoe commented Oct 26, 2018

Thank you. I have no issues with NC14 and keeweb :-) If you add a new kbdx file, need to do the scan again :-)

@arnowelzel
Copy link
Collaborator

Here neither. It would really be nice to implement the proposed changes - there are other apps there as well which require manual MIME type additions and I don't think that an API change in Nextcloud to avoid this manual step will come soon.

@onny
Copy link

onny commented Dec 11, 2018

Keeweb still works with Nextcloud 15 after adjusting appinfo/info.xml

@e-alfred
Copy link

e-alfred commented Jan 4, 2019

i gave @jhass a heads up on how another app solves the problem of registering mimetypes (Epub/Cbz/PDF reader app) over here but sadly it seems @jhass is not interested in it as I got no answer: #67 (comment)

@ravermeister
Copy link

Can someone create a zip for nc 15? Or is there a recent fork...?

@arnowelzel
Copy link
Collaborator

arnowelzel commented Jan 8, 2019

My fork is at https://github.com/arnowelzel/nextcloud-keeweb. I will add all required changes to make it usable with NC15 too.

@jhass what is your official strategy? You won't release a new Keeweb version until NC provides a working API for MIME type registration? In this case I'll fork it and offer it as "Keeweb2". Because I think it is way better to have an app which is a bit cumbersome to install than not having anything at all. And Keepass is the de facto standard for password safes and should be promoted wherever possible. Also see Keepass2Android - this supports Nextcloud as storage with an offline cache on the device.

@aalaesar
Copy link

Also see Keepass2Android - this supports Nextcloud as storage with an offline cache on the device.

Recently, there is a lot of good apps for keepass databases.
Keepass DX is also well integrated with Android and come with a special keyboard to avoid copy/pasting logins ( because the copy memory is shared between all apps).

@arnowelzel
Copy link
Collaborator

It seems we are finally getting somewhere. See the comments at #81. Thank you :-).

@ravermeister
Copy link

@arnowelzel do you have a succesful build to share with us?
I can't get the build script running on my machine with current nodejs...

@arnowelzel
Copy link
Collaborator

@ravermeister You can always downgrade nodejs if needed, see here for example: https://www.abeautifulsite.net/how-to-upgrade-or-downgrade-nodejs-using-npm

But I'll provide a build as soon as possible.

@ravermeister
Copy link

ravermeister commented Jan 26, 2019

Thanks for the hint, with this version:
echo390:~/repos/git/nextcloud-keeweb$ node -v v8.15.0
I was able to run bin/build master (assuming this is the correct output:)

keeweb@1.7.4 postinstall /home/ravermeister/repos/git/nextcloud-keeweb/keeweb-source
cd desktop && npm install

audited 1 package in 0.627s
found 0 vulnerabilities

npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.7 (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.7: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

audited 12497 packages in 15.803s
found 0 vulnerabilities

bower ENOENT No bower.json present

...the App installs and is shown, but when I want to access it I get an "Internal Server Error" on the menu Frame and the content is a blank page...

Update:
seems you have to comment out bower install and skip signing in bin/build
as there is now bower.json file inside keeweb-source and the build script aborts. currently building again...

this is my bin/build: https://pastebin.com/h5bEQmQv

...I give up, still blank page..

@arnowelzel
Copy link
Collaborator

To create a version which can just be copied to an existing Nextcloud instance, you only need to run make dist inside the keeweb folder. This creates keeweb/build/artifacts/appstore/keeweb.tar.gz with the content of the keeweb app folder in Nextcloud.

However - I was not lucky as well so far - same problem here even after applying b6584d0 - sorry :-(

@arnowelzel
Copy link
Collaborator

Ok, it there is a file missing after the build. See #16 - I have to sort out, how the build is done properly.

@arnowelzel
Copy link
Collaborator

arnowelzel commented Jan 26, 2019

Well - I did not figure out, how to get the build properly done. The missing file is copied from dist/index.html - but I don't find any dist folder anywhere after running the build.

So - I used templates/keeweb.php from my working version in NC14 and added the custom CSP code from here. I also applied the CSS modifications to make the app full width again. With these modifications it works now in NC15 as well. Of course you still have to do the manually add the required MIME type in Nextcloud, to be able to open *.kdbx files from the file view. But so far it looks good.

You can download a working archive here: https://nextcloud.0x0c.de/s/tcEzYLB5gb8AJEY

Extract the archive to the apps folder of Nextcloud and enable it in the settings, if needed. The version is 0.4.1, so this will be considered an upgrade in your Nextcloud instance, if the app was already enabled before copying the new version.

@ravermeister
Copy link

ravermeister commented Jan 27, 2019

the dist folder is in keeweb-source and there is a index.html too,
I merged the nc15-wip branch and made a new build but still no luck,
The keeweb Version in your zip is 1.5.0 current release is 1.7.4 maybe thats an issue...
so thanks for your work.

@arnowelzel
Copy link
Collaborator

Indeed - Keeweb 1.7.4 seems not to work at all. There is also a minor glitch with the CSP, but this only causes a warning in the console, I fixed this with arnowelzel@02d0519. But this does not change anything, Keeweb 1.7.4 still does not start and there is no error at all in the console to indicate what's going on.

@arnowelzel
Copy link
Collaborator

JFTR: I also updated https://nextcloud.0x0c.de/s/tcEzYLB5gb8AJEY with the fixed CSP.

@ravermeister
Copy link

Thanks, even Version 1.6.x does not work, I'll try with 1.5.x and tell if I was successful

@arnowelzel
Copy link
Collaborator

I think, this is related to the change introduced here: nextcloud/server@5b61ef9#diff-ea7fde28f6b4be25c841ed420fef5cdf

Also see #81 (comment) which mentions this.

@ravermeister
Copy link

ravermeister commented Jan 27, 2019

Yes I merged b6584d0

Into my fork but no luck, I get some errors during build which are ignored due to - - force flag. I'll keep trying to build 🙂 anyway your zip works 👍

@jhass
Copy link
Owner

jhass commented Feb 11, 2019

Try 0.5.0.

Never tested it for NC14 but it should still work. Or just jump to NC15 :)

Take care of the required manual steps as outlined in the readme!

@jhass jhass closed this as completed Feb 11, 2019
@oxivanisher
Copy link

It works great on my installation. Loving it! Thanks for all the work! :D ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests