From b9b9b6c2553de1b3f5a09130e5242e70a4e0135c Mon Sep 17 00:00:00 2001
From: Dana Robinson <43805+derobins@users.noreply.github.com>
Date: Wed, 25 Oct 2023 21:16:32 -0700
Subject: [PATCH] Fixed a file handle leak in the core VFD (#3779)

When opening a file with the core VFD and a file image, if the file
already exists, the file check would leak the POSIX file handle.

Fixes GitHub issue #635
---
 release_docs/RELEASE.txt | 7 +++++++
 src/H5FDcore.c           | 4 +++-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/release_docs/RELEASE.txt b/release_docs/RELEASE.txt
index 4e376f54542..b5b45d5f4c4 100644
--- a/release_docs/RELEASE.txt
+++ b/release_docs/RELEASE.txt
@@ -109,6 +109,13 @@ Bug Fixes since HDF5-1.14.3 release
 ===================================
     Library
     -------
+    - Fixed a file handle leak in the core VFD
+
+      When opening a file with the core VFD and a file image, if the file
+      already exists, the file check would leak the POSIX file handle.
+
+      Fixes GitHub issue #635
+
     - Dropped support for MPI-2
 
       The MPI-2 supporting artifacts have been removed due to the cessation
diff --git a/src/H5FDcore.c b/src/H5FDcore.c
index 08b714dfa34..1aa8d4bf19c 100644
--- a/src/H5FDcore.c
+++ b/src/H5FDcore.c
@@ -754,8 +754,10 @@ H5FD__core_open(const char *name, unsigned flags, hid_t fapl_id, haddr_t maxaddr
            ((file_image_info.buffer == NULL) && (file_image_info.size == 0)));
     memset(&sb, 0, sizeof(sb));
     if ((file_image_info.buffer != NULL) && !(H5F_ACC_CREAT & flags)) {
-        if (HDopen(name, o_flags, H5_POSIX_CREATE_MODE_RW) >= 0)
+        if ((fd = HDopen(name, o_flags, H5_POSIX_CREATE_MODE_RW)) >= 0) {
+            HDclose(fd);
             HGOTO_ERROR(H5E_FILE, H5E_FILEEXISTS, NULL, "file already exists");
+        }
 
         /* If backing store is requested, create and stat the file
          * Note: We are forcing the O_CREAT flag here, even though this is