Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8 stable release. #23449

Closed
15 of 19 tasks
mshima opened this issue Sep 8, 2023 · 44 comments
Closed
15 of 19 tasks

v8 stable release. #23449

mshima opened this issue Sep 8, 2023 · 44 comments
Labels
area: enhancement 🔧 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: blueprint 🐾 v8 $500 https://www.jhipster.tech/bug-bounties/
Milestone

Comments

@mshima
Copy link
Member

mshima commented Sep 8, 2023

Overview of the feature request

Track v8 blocking issues.

TODO:

Breaking changes:

Migrate blueprints and check/implement individual requirements:

Motivation for or Use Case
Related issues or PR
  • Checking this box is mandatory (this is just to show you read everything)
@deepu105
Copy link
Member

I don't think we have to wait for all blueprints to migrate as they can migrate at their own pace

@nicolas63
Copy link
Member

I have create the issue on the jhipter-dotnet blueprint but i need your help to migrate

@mraible mraible added $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ $500 https://www.jhipster.tech/bug-bounties/ labels Sep 21, 2023
@mshima
Copy link
Member Author

mshima commented Sep 23, 2023

I have create the issue on the jhipter-dotnet blueprint but i need your help to migrate

I’ve started the migration.

@mraible
Copy link
Contributor

mraible commented Sep 27, 2023

@mshima I appreciate all the work you're doing to make JHipster 8.0 happen. Please let me know if there's anything I can do to help!

@mshima
Copy link
Member Author

mshima commented Sep 29, 2023

@mraible some help updating heroku generator would be great. We should target heroku for 8.1.

With micronaut (java) and dotnetcore (2 client generators and a server) been updated.
I would say we should go ahead and release a RC as soon as possible and final a week later.

I will take a look at ci-cd generator and nodejs and ionic blueprints this weekend.

I hope to have a simultaneous release for every migrated blueprint.

@deepu105
Copy link
Member

deepu105 commented Oct 4, 2023 via email

@mshima
Copy link
Member Author

mshima commented Oct 13, 2023

@deepu105 any news about a new release?

@deepu105
Copy link
Member

deepu105 commented Oct 13, 2023 via email

@mraible
Copy link
Contributor

mraible commented Oct 30, 2023

I might've fixed #23883. If it works, can you create a release this week, @deepu105?

@mshima
Copy link
Member Author

mshima commented Oct 30, 2023

@mshima I tried creating a new micro frontends architecture using:

jhipster jdl reactive-mf.jdl --monorepository --workspaces

It gives me a bunch of warnings. Do I need to update the reactive-mf.jdl file to add a custom id?

WARNING! Microservice entities should have a custom id to make sure gateway and microservice types won't conflict
WARNING! Microservice entities should have a custom id to make sure gateway and microservice types won't conflict
WARNING! Microservice entities should have a custom id to make sure gateway and microservice types won't conflict
WARNING! Microservice entities should have a custom id to make sure gateway and microservice types won't conflict

@mraible fixed in #24046.

@mraible
Copy link
Contributor

mraible commented Oct 31, 2023

👀 Our quality gate is looking good!

Screenshot 2023-10-30 at 8 20 54 PM

@mshima @DanielFran Do we need anything else before releasing 8.0?

@DanielFran
Copy link
Member

@mraible I believe everything is done.

We still have this PR to remove AngularJS locale configuration but we do not have anything to replace that could manage i18n. But I do not think this is blocking the release.

And I realised that today Neo4J is broken: https://github.com/hipster-labs/jhipster-daily-builds/actions/runs/6702088203

@DanielFran
Copy link
Member

DanielFran commented Oct 31, 2023

@mshima Is this #24028 blocking the release?

@mshima
Copy link
Member Author

mshima commented Oct 31, 2023

@mshima Is this #24028 blocking the release?

It's a quite annoying bug, not sure how much the user is affected.
Are you planning to cut the release?

@mshima
Copy link
Member Author

mshima commented Oct 31, 2023

@mshima Is this #24028 blocking the release?

This is actually jhipster v7 behavior, since we used to delegate to the local generator-jhipster.

@DanielFran
Copy link
Member

@mshima Is this #24028 blocking the release?

It's a quite annoying bug, not sure how much the user is affected. Are you planning to cut the release?

I believe it was supposed to create the final version now, not a new RC version

@mshima
Copy link
Member Author

mshima commented Oct 31, 2023

@mshima Is this #24028 blocking the release?

It's a quite annoying bug, not sure how much the user is affected. Are you planning to cut the release?

I believe it was supposed to create the final version now, not a new RC version

Yes, there are huge changes to the core since the RC, but I think it's ok to go final.
I want to know if you are planning to release in the middle of this week.

@mraible
Copy link
Contributor

mraible commented Oct 31, 2023

@mshima What's your preference? As the primary contributor to 8.0, we're happy to follow your advice.

@deepu105 Can you do a release today or tomorrow if everyone approves? It might be fun to release on Halloween! 👻🎃

@mshima mshima mentioned this issue Nov 1, 2023
6 tasks
@mshima
Copy link
Member Author

mshima commented Nov 1, 2023

One last PR #24067.

@MarkingYang
Copy link

MarkingYang commented Nov 1, 2023 via email

@mraible
Copy link
Contributor

mraible commented Nov 1, 2023

@mshima I'm testing this blog post and when I run jhipster jdl microservices.jdl, it still has warnings:

WARNING! Microservice entities should have a custom id to make sure gateway and microservice types won't conflict
WARNING! Microservice entities should have a custom id to make sure gateway and microservice types won't conflict
WARNING! Microservice entities should have a custom id to make sure gateway and microservice types won't conflict
WARNING! Microservice entities should have a custom id to make sure gateway and microservice types won't conflict
WARNING! Microservice entities should have a custom id to make sure gateway and microservice types won't conflict

Here's the JDL:

application {
  config {
    baseName gateway
    packageName com.okta.developer.gateway
    applicationType gateway
    authenticationType oauth2
    buildTool gradle
    clientFramework vue
    prodDatabaseType postgresql
    serviceDiscoveryType consul
    testFrameworks [cypress]
  }
  entities Blog, Post, Tag, Product
}

application {
  config {
    baseName blog
    packageName com.okta.developer.blog
    applicationType microservice
    authenticationType oauth2
    buildTool gradle
    databaseType neo4j
    enableHibernateCache false
    serverPort 8081
    serviceDiscoveryType consul
  }
  entities Blog, Post, Tag
}

application {
  config {
    baseName store
    packageName com.okta.developer.store
    applicationType microservice
    authenticationType oauth2
    buildTool gradle
    databaseType mongodb
    enableHibernateCache false
    serverPort 8082
    serviceDiscoveryType consul
  }
  entities Product
}

entity Blog {
  name String required minlength(3)
  handle String required minlength(2)
}

entity Post {
  title String required
  content TextBlob required
  date Instant required
}

entity Tag {
  name String required minlength(2)
}

entity Product {
  title String required
  price BigDecimal required min(0)
  image ImageBlob
}

relationship ManyToOne {
  Blog{user(login)} to User with builtInEntity
  Post{blog(name)} to Blog
}

relationship ManyToMany {
  Post{tag(name)} to Tag{post}
}

paginate Post, Tag with infinite-scroll
paginate Product with pagination

microservice Product with store
microservice Blog, Post, Tag with blog

deployment {
  deploymentType docker-compose
  appsFolders [gateway, blog, store]
  dockerRepositoryName "mraible"
}

The rest of the tutorial works, there's just this these warnings at the beginning.

@mshima
Copy link
Member Author

mshima commented Nov 1, 2023

@mraible some context of this warning is at #23850

At the PR we started relying on the frontend type to do some conversions and failed due to id different types related to different databases (gateway uses postgres with Long ids, microservice uses cassandra with UUID ids).

We used to carry on databaseType at the entity level, but this is quite hackish and hard to maintain, and we are decoupling jdl from business.
As alternative, we are advising the user to specify the entity's id type which looks much more reliable and cleaner than carrying databaseType around at entity level.

@deepu105
Copy link
Member

deepu105 commented Nov 1, 2023 via email

@mraible
Copy link
Contributor

mraible commented Nov 1, 2023

As alternative, we are advising the user to specify the entity's id type which looks much more reliable and cleaner than carrying databaseType around at entity level.

How do I change my JDL to get rid of this warning?

@mshima
Copy link
Member Author

mshima commented Nov 1, 2023

As alternative, we are advising the user to specify the entity's id type which looks much more reliable and cleaner than carrying databaseType around at entity level.

How do I change my JDL to get rid of this warning?

Neo4J and MongoDB default primary keys are String and there is no entity served in Gateway.
Add id String field to every entity.

@mraible
Copy link
Contributor

mraible commented Nov 1, 2023

I can confirm that adding id String to the JDL makes the warning go away. Here's the commit with the update. Is required necessary for primary keys?

@mshima
Copy link
Member Author

mshima commented Nov 1, 2023

I can confirm that adding id String to the JDL makes the warning go away. Here's the commit with the update. Is required necessary for primary keys?

No, the id should imply required.
Maybe you want to add the Id annotation @Id id String I think is prettier.

@mraible
Copy link
Contributor

mraible commented Nov 1, 2023

OK, updated in oktadev/okta-blog@9f4f171.

In the generated Java classes, I noticed the biggest difference is removing required results in @NotNull being removed:

-    @NotNull
     @Id
     private String id;

@deepu105 deepu105 modified the milestones: 8.1.0, 8.0.0 Dec 11, 2023
@mshima
Copy link
Member Author

mshima commented May 20, 2024

@DanielFran
Copy link
Member

@mshima approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: enhancement 🔧 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: blueprint 🐾 v8 $500 https://www.jhipster.tech/bug-bounties/
Projects
None yet
Development

No branches or pull requests

6 participants