Merge pull request #34 from Trott/fix-leak

Fix leak, add test, for #33
jhnns · Oct 29, 2014 · 6040c0c · 6040c0c
2 parents 93d3907 + 7e25ede
commit 6040c0c
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/rewire.js b/lib/rewire.js
@@ -19,7 +19,8 @@ var srcs = {
 function internalRewire(parentModulePath, targetPath) {
     var targetModule,
         prelude,
-        appendix;
+        appendix,
+        src;
 
     // Checking params
     if (typeof targetPath !== "string") {

diff --git a/test/rewire.test.js b/test/rewire.test.js
@@ -16,6 +16,14 @@ describe("rewire", function () {
             fs.renameSync(fakeNodeModules, path.resolve(__dirname, "testModules/node_modules"));
         }
     });
+    it("should keep not leak globals", function () {
+        // This test should run first, as the global space may be already polluted if 
+        //   require("../") is run before this test.
+        var originalGlobalKeys = Object.keys(global),
+            rewire = require("../"),
+            emptyModule = rewire("./testModules/emptyModule.js");
+        expect(Object.keys(global)).to.eql(originalGlobalKeys);
+    });
     it("should pass all shared test cases", function () {
         require("./testModules/sharedTestCases.js");
     });