You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The vignette says the predictor uses 5 genes, as does the paper, but this is hard to see from the code. If true, I suggest you to be more clear on this.
You apply the predictor to your own training data set (I think). While useful, the call to cycle_npreg_outsample makes it a bit unclear what the requirement is for prediction. For example, should it have the same row names, have the same gene ordering etc?
The text was updated successfully, but these errors were encountered:
@jhsiao999 If I understand the vignette correctly, the example uses 101 genes to predict cell cycle, not 5. I do agree with @kasperdanielhansen it is a bit confusing because you talk about only needing 5 genes at the beginning of the vignette.
I also agree that it would be helpful if help(cycle_npreg_outsample) would give more information about the Y_test input argument. Currently it just says this:
Y_test: A ‘SingleCellExperiment’ object.
In particular, it is unclear how the Y_test input is supposed to align with the Y input to cycle_npreg_insample.
@kasperdanielhansen Note there is also an example here that might help because it illustrates the use of both cycle_npreg_insample and cycle_npreg_outsample.
The vignette says the predictor uses 5 genes, as does the paper, but this is hard to see from the code. If true, I suggest you to be more clear on this.
You apply the predictor to your own training data set (I think). While useful, the call to
cycle_npreg_outsample
makes it a bit unclear what the requirement is for prediction. For example, should it have the same row names, have the same gene ordering etc?The text was updated successfully, but these errors were encountered: