Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings about GHAs (checkout@v2, ubuntu-latest) #604

Closed
KatherineCox opened this issue Dec 7, 2022 · 6 comments
Closed

Warnings about GHAs (checkout@v2, ubuntu-latest) #604

KatherineCox opened this issue Dec 7, 2022 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@KatherineCox
Copy link
Contributor

KatherineCox commented Dec 7, 2022

(Copied from a run on AnVIL_Template)

Load user automation choices
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout@v2

Render all output courses: .github#L1
ubuntu-latest pipelines will use ubuntu-22.04 soon. For more details, see actions/runner-images#6399

Render bookdown
Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout@v2

From the links, looks like we have until Summer 2023 to update Node.js, and March 2023 to confirm ubuntu-latest isn't a problem.

Also related: #584

@KatherineCox KatherineCox added the bug Something isn't working label Dec 7, 2022
@cansavvy
Copy link
Collaborator

I've done some preliminary work on this but haven't found the most elegant solution. This probably should be bumped in priority since this is happening this year and affects soooo many repositories.

@cansavvy
Copy link
Collaborator

@cansavvy
Copy link
Collaborator

I've not been able to find the warning messages posted above. Can you add a screenshot that shows me where you saw them specifically, @KatherineCox ?

@cansavvy
Copy link
Collaborator

Ah I found them:
Screen Shot 2023-01-31 at 12 01 37 PM

Unfortunately I think this is up to the creators of the actions that we are using and there's not much that we can do but check if they have updated versions that use Node.js 16.

I'll start going through to see if there are updated versions we can use. Oh boy.

@KatherineCox
Copy link
Contributor Author

@cansavvy haha, you're ahead of me. I was coming to show where I'd seen the warnings, and then to mention upgrading actions/checkout@v2 to v3, but looks like you're on top of things! :)

@cansavvy
Copy link
Collaborator

cansavvy commented Feb 1, 2023

This should* be addressed now. The only thing that might not be is the OTTR-reports part. But we don’t have any direct set-output s there. So I think we’ve done what we can.

@cansavvy cansavvy closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants