Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video expand buttons gone? Why? #17

Closed
cansavvy opened this issue Aug 27, 2021 · 2 comments · Fixed by #20
Closed

Video expand buttons gone? Why? #17

cansavvy opened this issue Aug 27, 2021 · 2 comments · Fixed by #20

Comments

@cansavvy
Copy link
Contributor

This is working as far as I can tell, but the one thing that's odd/not working really is the corner part in the videos are gone?

Screen Shot 2021-08-26 at 8 24 20 PM

This is what the tags for the above look like (also note that "middle" doesn't work -- only "center").

{height: "400px", width: "672", align: "middle" type: "video" poster: "http://img.youtube.com/vi/VOCYL-FNbr0/mqdefault.jpg"}
![Click on the lower right corner to expand the screen](https://www.youtube.com/watch?v=VOCYL-FNbr0).
{height: "400px", width: "672", align: "middle" type: "video" poster: "http://img.youtube.com/vi/VOCYL-FNbr0/mqdefault.jpg"}
![Click on the lower right corner to expand the screen](https://www.youtube.com/watch?v=VOCYL-FNbr0).

Originally posted by @cansavvy in #14 (comment)

@carriewright11
Copy link
Member

Repeating this over here:

This is working as far as I can tell, but the one thing that's odd/not working really is the corner part in the videos are gone?

They aren't gone... it shows up after pressing play... but idk how to convey that more concisely/ assumed people when they saw the word video would press play. They can actually press twice on the right corner (on nothing) and it will expand- you don't have to click the center to play.

The text appears to be centered but not the video... let me check how I did that...

Ok here is an example of mine:

{type: video, poster: 'http://img.youtube.com/vi/VOCYL-FNbr0/mqdefault.jpg',height: "400px", width: "100%", align: "middle"}
Click lower right corner of video to expand

I noticed that the comma is missing before align:"middle:" on the code so maybe that is why? Also I only tested with type:video, poster: at the beginning. Idk but maybe that makes a difference.

@cansavvy
Copy link
Contributor Author

Yeah there's some commas we need I'm pretty sure. I'm adding them back and also adding a new check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants