-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Video expand buttons gone? Why? #17
Comments
Repeating this over here:
They aren't gone... it shows up after pressing play... but idk how to convey that more concisely/ assumed people when they saw the word video would press play. They can actually press twice on the right corner (on nothing) and it will expand- you don't have to click the center to play. The text appears to be centered but not the video... let me check how I did that... Ok here is an example of mine: {type: video, poster: 'http://img.youtube.com/vi/VOCYL-FNbr0/mqdefault.jpg',height: "400px", width: "100%", align: "middle"} I noticed that the comma is missing before align:"middle:" on the code so maybe that is why? Also I only tested with type:video, poster: at the beginning. Idk but maybe that makes a difference. |
Yeah there's some commas we need I'm pretty sure. I'm adding them back and also adding a new check. |
This is working as far as I can tell, but the one thing that's odd/not working really is the corner part in the videos are gone?
This is what the tags for the above look like (also note that "middle" doesn't work -- only "center").
Originally posted by @cansavvy in #14 (comment)
The text was updated successfully, but these errors were encountered: