-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a function in leanbuild for handling iframes aka leanbuild::include_iframe() #6
Comments
I can edit the For videos that would result in something like this: For embedded files it would result in:
|
What I'm trying to do is move the code from your scripts into the package itself so that we don't have to call those scripts but we still have the functionality from those scripts automatically when someone installs the leanbuild package. I think what you're describing would still require we use extra scripts. |
Yes, sorry I was in the middle of writing a new comment to say that I thought I misunderstood you. I thought you were talking about cases of include_iframe() instead of include_url. |
I agree that we want to allow people to just use leanbuild - that is what I was hoping for as well and planning to do but just hadn't done yet. I figured we could incorporate my scripts into the package to just see if this worked and then work to functionalize my scripts, but it's ok to skip that step. |
I don't think leanbuild does anything with iframes currently (not thinking about calling my scripts within it) so I got confused. |
Ah. Yeah that's my point. I think we should make it so leanbuild does handle iframes. I probably didn't describe this well but that was my intent of this issue. |
After chatting with @carriewright11 my understanding is that these are the things that are broken that I'm going to work on integrating fixes into the package:
|
This has been accomplished. |
There's a need for a
include_iframe()
function here. See https://github.com/jhudsl/leanbuild/pull/3/files#r692949964 for more context.The idea would be to just supply an iframe link and turn it into something of this format:
currently iframe links need to be supplied like:
I'm adding these to our test_cases.Rmd in https://github.com/jhudsl/DaSL_Course_Template_Bookdown/blob/main/03-test_cases.Rmd
The text was updated successfully, but these errors were encountered: