Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [OFFICIAL] Generated Issue: ParserException #535

Closed
1 task done
irfan-dahir opened this issue Oct 17, 2023 · 1 comment
Closed
1 task done

🐛 [OFFICIAL] Generated Issue: ParserException #535

irfan-dahir opened this issue Oct 17, 2023 · 1 comment
Labels
bug critical escalated issues that need immediate attention and fixes

Comments

@irfan-dahir
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

No response

Expected Behavior

The API should have returned a successful response with data.¤t_behavior=The API has returned an error:
Jikan\Exception\ParserException
Status code: 0
Message: Failed to parse 'https://myanimelist.net/manga/143751/'
Trace: /var/www/jikan-rest/vendor/jikan-me/jikan/src/Exception/ParserException.php on line 24

Steps To Reproduce

Http Request: `GET /v4/manga/143751

Environment

No response

Anything else?

As reported on discord: https://discord.com/channels/460491088004907029/1163633893933580318

@irfan-dahir irfan-dahir added bug critical escalated issues that need immediate attention and fixes labels Oct 17, 2023
@irfan-dahir
Copy link
Collaborator Author

irfan-dahir commented Oct 17, 2023

image
MAL can return empty title synonyms. This is an edge case on an unapproved entry.
I'm not making titles nullable, will just return an empty string instead on the API to maintain BC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug critical escalated issues that need immediate attention and fixes
Projects
None yet
Development

No branches or pull requests

1 participant