Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for web-streams-polyfill@3.0.0 #188

Open
heri16 opened this issue Oct 22, 2020 · 4 comments
Open

Support for web-streams-polyfill@3.0.0 #188

heri16 opened this issue Oct 22, 2020 · 4 comments

Comments

@heri16
Copy link

heri16 commented Oct 22, 2020

web-streams-polyfill@3.0.0 has been released and includes some breaking changes.

https://github.com/MattiasBuelens/web-streams-polyfill/blob/master/CHANGELOG.md

Is there any intent to support it?

@jimmywarting
Copy link
Owner

Is there any intent to support it?

Um, yea... do you know what is breaking?

@a-wing
Copy link

a-wing commented Oct 22, 2020

I use web-streams-polyfill@3.0.0

But. Did not find any problems

btw: If use import should import 'web-streams-polyfill/dist/polyfill.min.js'

@EtienneBruines
Copy link

Specifically for us, we ran into an incompatibility:

    function IsWritableStream(x) {
        if (!typeIsObject(x)) {
            return false;
        }
        if (!Object.prototype.hasOwnProperty.call(x, '_writableStreamController')) {
            return false;
        }
        return true;
    }

This function (which is part of the web-streams-polyfill) returns false when looking at StreamSaver's createWriteStream result.

This result in an error when using pipeTo:

ReadableStream.prototype.pipeTo's first argument must be a WritableStream

@jimmywarting
Copy link
Owner

Yea, it's a big issue with interchangeable versions of native and polyfilled streams
u pretty much have to use the same version of readable+writable stream for them to work together

Possible solution i have waited long for: MattiasBuelens/web-streams-polyfill#20

related issues:
MattiasBuelens/web-streams-polyfill#70
MattiasBuelens/web-streams-polyfill#75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants