Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart session feature doesn't work #924

Open
Kyogre opened this issue Nov 25, 2023 · 3 comments
Open

Restart session feature doesn't work #924

Kyogre opened this issue Nov 25, 2023 · 3 comments

Comments

@Kyogre
Copy link

Kyogre commented Nov 25, 2023

Describe the bug
Nothing happens when I perform Restart session on a tab.

To Reproduce
Steps to reproduce the behavior:

  1. in SP connect to any ssh session (I am using SP with combination of kitty portable v0.76.1.13)
  2. open context menu of any tab
  3. press Restart session
  4. Nothing happens

Expected behavior
Session restarts

Desktop (please complete the following information):

  • OS: Windows 10 Pro 22H2
  • Version 1.5.0.0 zip
@pkumarg
Copy link

pkumarg commented Dec 15, 2023

Are you trying to restart session when it's already connected? Because on already started session which just working find this option is not valid. Ideally it should be greyed out if session is started and not interrupted by any means.

@Kyogre
Copy link
Author

Kyogre commented Dec 15, 2023

restart session when it's already connected?

Yes.

on already started session which just working find this option is not

No no no. Maybe the user can't exit vim and just want to restart the session? 🙃
Anyway in kitty this feature is working fine.

@pkumarg
Copy link

pkumarg commented Dec 19, 2023

OK, if that's the requirement, then I think we need a fix. Anyway it looks kitty supports this kind of restart, and putty doesn't even show this option when session connected.

And it could be possible that SuperPutty is mostly tested with putty. That's why there is no action on session restart click when connected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants