Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please export Node,Element,AttributeNode etc. internal classes #235

Open
Torcsi opened this issue Mar 21, 2018 · 0 comments
Open

Please export Node,Element,AttributeNode etc. internal classes #235

Torcsi opened this issue Mar 21, 2018 · 0 comments

Comments

@Torcsi
Copy link

Torcsi commented Mar 21, 2018

During a (successful) implementation of SaxonJS with xmldom we needed the interface classes for the purpose of testing oNode instanceof Node.

https://www.w3.org/TR/2000/REC-DOM-Level-2-Core-20001113/core.html says in its TOC

1.2. Fundamental Interfaces

DOMException, ExceptionCode, DOMImplementation, DocumentFragment, Document, Node, NodeList, NamedNodeMap, CharacterData, Attr, Element, Text, Comment

Can you please add the exports in domparser and dom for these internal classes/interfaces? This is minor change but there may be some potential threats I am not aware of.

Thanks.

Btw. when exporting these (modifying manually the exports), SaxonJS gave definite life signs under node js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant