Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a builtin Midi phrase editor #263

Closed
hajdam opened this issue Jan 27, 2022 · 4 comments
Closed

Add a builtin Midi phrase editor #263

hajdam opened this issue Jan 27, 2022 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed high priority
Milestone

Comments

@hajdam
Copy link
Contributor

hajdam commented Jan 27, 2022

If you maybe would like to include some MIDI player, there is an example of basic one written in Java:

https://mac.softpedia.com/get/Audio/MidiSwing.shtml

It was freeware with promise of open source, but I assume author passed away, but I believe it could be tweaked for some basic use...

I mean there is also Frinika, but it's somewhat bigger beast...

Best regards,
HajdaM

@jjazzboss jjazzboss added the enhancement New feature or request label Jan 27, 2022
@jjazzboss
Copy link
Owner

jjazzboss commented Jan 27, 2022

I don't see the need for a player to play external Midi files... What use-case do you have in mind?

@hajdam
Copy link
Contributor Author

hajdam commented Jan 27, 2022

I don't see the need for a player to play external Midi files... What use-case do you have in mind?

It's more like an editor - I thought because there's option to use external editor, that it might be useful to include directly some basic one or allow direct editing of styles with it, but never mind then...

@jjazzboss
Copy link
Owner

jjazzboss commented Jan 27, 2022

Ah you mean a piano-roll editor ? Yes that would be good to have such graphical component to edit a SizedPhrase. Do you want to do it ? As a starting point you could have a look at this component: https://github.com/jjazzboss/JJazzLab-X/blob/master/Phrase/src/org/jjazz/phrase/api/ui/PhraseBirdsEyeViewComponent.java

@jjazzboss jjazzboss added help wanted Extra attention is needed high priority labels Apr 28, 2022
@jjazzboss jjazzboss changed the title Suggestion for possible simple MIDI player/editor to include with app Suggestion for possible simple MIDI editor to include with app Apr 28, 2022
@jjazzboss jjazzboss added this to the 4.0 milestone Dec 5, 2022
@jjazzboss jjazzboss changed the title Suggestion for possible simple MIDI editor to include with app Add a builtin Midi phrase editor Dec 5, 2022
@jjazzboss
Copy link
Owner

Implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed high priority
Projects
None yet
Development

No branches or pull requests

2 participants