Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADPCM decode doesn't optionally remove sync frames #9

Open
dh1df opened this issue Dec 25, 2023 · 5 comments
Open

ADPCM decode doesn't optionally remove sync frames #9

dh1df opened this issue Dec 25, 2023 · 5 comments

Comments

@dh1df
Copy link

dh1df commented Dec 25, 2023

There seems to be no counterpart to
csdr adpcm -e -s
Just using
csdr adpcm -d
creates distortions in the audio from the sync frames and
csdr adpcm -d -s
doesn't improve this, the sync flag is ignored in the adpcm decoder.

@jketterl
Copy link
Owner

jketterl commented Jan 1, 2024

This is mostly due to the fact that the adpcm decoder does not currently implement the sync mode. I never really go to the part of adding that.

The sync mode was conceived as a way to support late entry, i.e. the ability to start decoding a stream of data at any given entry point (as opposed to right from the beginning). What exactly are you using this feature for?

@dh1df
Copy link
Author

dh1df commented Jan 1, 2024

I have written a python script which gets a adpcm stream from OpenWebRX for further processing (i.e. recording and uploading). However there seems to be no simple way to get rid of the sync frames, they distort the audio. I have hacked together a small program which removes them, but it is slow and horrible :-) Curiously and off-topic also the sample rate has issues, I have requested 11025 and seem to be getting something like 10144. All worked well on an older OpenWebRX version without sync frames

@jketterl
Copy link
Owner

jketterl commented Jan 1, 2024

Yeah sorry but I can only repeat this whenever a use case like this comes up: The OpenWebRX websockets are considered internal. They are subject to change. They're not meant to be consumed by third-party processes...

@dh1df
Copy link
Author

dh1df commented Jan 1, 2024

So is there an official API?

@jketterl
Copy link
Owner

jketterl commented Jan 1, 2024

No, there isn't. OpenWebRX is not a multi-purpose streaming service that is intended to feed third-party applications. You may need to look into a different project for that purpose. Or maybe wait until the project matures to that degree, but I can't give you any guarantees that that will happen. It is not on the roadmap for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants