Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black color missing when importing lospec palette .ase #5

Open
hsandt opened this issue May 3, 2022 · 2 comments
Open

Black color missing when importing lospec palette .ase #5

hsandt opened this issue May 3, 2022 · 2 comments

Comments

@hsandt
Copy link

hsandt commented May 3, 2022

When you Import ASE File (Browse...) and select a color palette in Photoshop ASE format downloaded from the lospec website, the resulting palette will lack black as first color.

Tried with:

2022-05-03 Copper Tech via ASE missed black

Because I don't have Photoshop, I can't verify that said palettes didn't missing the black color to start with. I didn't find a palette that as black not as first color to check if the issue occurs at other places (this matters if your parser skips any 0 at the beginning of the file, for instance; but I'd be surprised that there is no header in the format to avoid that issue).

Importing the equivalent PNG works fine.

2022-05-03 Copper Tech via PNG is OK

@hsandt
Copy link
Author

hsandt commented May 3, 2022

I spot an error in the console log when importing the ASE:

[SwatchASEFile] File header did not match ASEF �Ā�Ā
UnityEngine.Debug:LogErrorFormat (string,object[])
swatchr.SwatchASEFile:.ctor (byte[]) (at Assets/ColorPalettes/swatchr-master-2019-03-30/swatchr/InternalScripts/SwatchASEFile.cs:35)
swatchr.SwatchASEFile:.ctor (string) (at Assets/ColorPalettes/swatchr-master-2019-03-30/swatchr/InternalScripts/SwatchASEFile.cs:23)
swatchr.SwatchCreator:ImportASEFileBrowse () (at Assets/ColorPalettes/swatchr-master-2019-03-30/swatchr/Editor/SwatchCreator.cs:79)

So maybe the ASE was invalid indeed, or the parser failed to recognize the header and skipped the black color at the beginning along (due to 0?) for some reason.

@jknightdoeswork
Copy link
Owner

jknightdoeswork commented May 3, 2022

Thanks for reporting this bug and for using this project. Can you refer me to the exact .ase file? EDIT: I see there is a .ase file at those links. I'll look into it! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants