Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sender encryption #21

Closed
wants to merge 8 commits into from
Closed

Conversation

ilyakatz
Copy link
Contributor

My attempt to fix #20

@ilyakatz
Copy link
Contributor Author

I see that I broke the build, but I can't really understand why. Any thoughts?

@jkraemer
Copy link
Owner

Don't know about the build - only 2.0 failed on travis, on my machine it works, maybe just a local Travis CI hickup.

However correct me if I'm wrong, but your patch seems incomplete and will actually not do anything as it is now. It is not enough to add the sender's key to the :keys array, you also have to add the actual sender of the mail to the array of email addresses that ends up as the :receivers option in GpgmeHelper::encrypt. Only then the sender's key will be picked up as an encryption target.

I think the best place to add the sender to that array would be in Mail::Gpg::encrypt.

@ilyakatz
Copy link
Contributor Author

Oh, I didn't realize that. Ok, will take a look at how to rework this.

@jkraemer jkraemer closed this Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Encrypt with senders public key
2 participants