Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import statements in statcast docs #228

Merged
merged 3 commits into from
Aug 11, 2021

Conversation

wfordh
Copy link
Contributor

@wfordh wfordh commented Aug 1, 2021

Fixing issues with documentation for statcast docs brought up by #225

@bdilday
Copy link
Contributor

bdilday commented Aug 1, 2021

I think it'd be a good idea to expose these at the top level, example, in pybaseball/__init__.py

from .statcast_batter import (
    statcast_batter,
    statcast_batter_exitvelo_barrels,
    statcast_batter_expected_stats,
    statcast_batter_percentile_ranks,
    statcast_batter_pitch_arsenal,
)

@wfordh
Copy link
Contributor Author

wfordh commented Aug 1, 2021

Ah so that's why I could import statcast_batter() directly and couldn't with these. I can add the functions into pybaseball/__init__.py like that for all of them and then revert back to the original documentation

Reverting so I can add functions to __init__.py instead of changing docs.
This reverts commit 5748374.
@schorrm
Copy link
Collaborator

schorrm commented Aug 3, 2021

LGTM, @bdilday all good?

@schorrm schorrm merged commit 85c9ca7 into jldbc:master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants