Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename teams to teams_core #263

Merged
merged 1 commit into from
Apr 29, 2022
Merged

Rename teams to teams_core #263

merged 1 commit into from
Apr 29, 2022

Conversation

tjburch
Copy link
Collaborator

@tjburch tjburch commented Apr 23, 2022

#251 introduced a bug in __init__.py after updating teams() to teams_core(). This updates the call to the new teams_core().

before:

In [1]: from pybaseball.batting_stats_range import batting_stats_range
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
Input In [1], in <cell line: 1>()
----> 1 from pybaseball.league_batting_stats import batting_stats_range

File ~/Documents/github/pybaseball/pybaseball/__init__.py:79, in <module>
     77 from .lahman import schools
     78 from .lahman import series_post
---> 79 from .lahman import teams_core
     80 from .lahman import teams_upstream
     81 from .lahman import teams_franchises

ImportError: cannot import name 'teams_core' from 'pybaseball.lahman' (/Users/tburch/Documents/github/pybaseball/pybaseball/lahman.py)

after:

In [1]: from pybaseball.league_batting_stats import batting_stats_range

In [2]: quit()

I will note that #260 also took care of this, but it's probably preferable to continue with the teams_core name rather than roll back to teams and also segment this out to an independent PR.

My guess is this also covers issue #253.

@schorrm schorrm merged commit f6f2c02 into jldbc:master Apr 29, 2022
@tjburch tjburch deleted the teams_core_fix branch April 29, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants