Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 284 top prospects not working. #307

Merged
merged 3 commits into from
Feb 25, 2023
Merged

Issue 284 top prospects not working. #307

merged 3 commits into from
Feb 25, 2023

Conversation

bryanpeabody
Copy link

@bryanpeabody bryanpeabody commented Jan 21, 2023

Finished the work KyleDirks started and added sanitization around team names, blue Jays, blue-jays, etc are changed to lowercase bluejays so all combinations work. Added some error checking for empty team names as well.

…m names, blue Jays, blue-jays, etc are changed to bluejays so all combinations work. Added some error checking for empty team name as well.
@BrayanMnz
Copy link
Contributor

It seems ok for me,
Could be merged per my revision.
Thoughts ? @tjburch, @schorrm

Copy link
Collaborator

@tjburch tjburch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, thanks for taking care of it. I left only one piece of feedback (that I don't feel overly strong about).

pybaseball/teamid_lookup.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@tjburch tjburch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @schorrm if you want to give this a look over and merge it when you have a chance. Could be done before version bumping so we get it in.

@tjburch tjburch merged commit e8ff4c2 into jldbc:master Feb 25, 2023
@tjburch tjburch mentioned this pull request Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants