Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix validation of drag-enabled prop to avoid Vue warnings #205

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

jledentu
Copy link
Owner

@jledentu jledentu commented Mar 31, 2023

This MR fixes warning below, in 2.x branch:

[Vue warn]: Invalid prop: type check failed for prop "dragEnabled". Expected Boolean, got Function.

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a188316) 99.42% compared to head (8cc6054) 99.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##              2.x     #205   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files           4        4           
  Lines         175      175           
  Branches       44       44           
=======================================
  Hits          174      174           
  Misses          1        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jledentu jledentu merged commit 9455989 into 2.x Mar 31, 2023
@jledentu jledentu deleted the fix-drag-enabled-validation branch March 31, 2023 10:35
github-actions bot pushed a commit that referenced this pull request Mar 31, 2023
## [2.1.1](v2.1.0...v2.1.1) (2023-03-31)

### Bug Fixes

* fix validation of drag-enabled prop to avoid Vue warnings ([#205](#205)) ([9455989](9455989))
@github-actions
Copy link

🎉 This PR is included in version 2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant