Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(virtualization): add virtualize prop #210

Merged
merged 3 commits into from
May 19, 2023
Merged

feat(virtualization): add virtualize prop #210

merged 3 commits into from
May 19, 2023

Conversation

jledentu
Copy link
Owner

This PR adds virtualize and itemHeight props that enables list virtualization.

  • virtualize: true enables virtualization, so a more performant rendering when some nodes contains a lot of children
  • itemHeight is used to estimate the height of lists when virtualization is enabled

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Patch coverage: 80.76% and project coverage change: -3.07 ⚠️

Comparison is base (a394a5a) 96.43% compared to head (91557ac) 93.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.x     #210      +/-   ##
==========================================
- Coverage   96.43%   93.36%   -3.07%     
==========================================
  Files           9       10       +1     
  Lines        1458     1704     +246     
  Branches      137      160      +23     
==========================================
+ Hits         1406     1591     +185     
- Misses         51      112      +61     
  Partials        1        1              
Impacted Files Coverage Δ
src/components/FinderList.vue 82.95% <70.05%> (-17.05%) ⬇️
src/utils/drag-counter.js 95.34% <95.34%> (ø)
src/components/Finder.vue 92.90% <100.00%> (+0.31%) ⬆️
src/components/FinderListDropZone.vue 98.49% <100.00%> (+1.59%) ⬆️
src/utils/tree-model.js 93.31% <100.00%> (-1.08%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jledentu jledentu merged commit fad3f78 into 2.x May 19, 2023
@jledentu jledentu deleted the virtualization branch May 19, 2023 14:02
github-actions bot pushed a commit that referenced this pull request May 19, 2023
# [2.2.0](v2.1.2...v2.2.0) (2023-05-19)

### Features

* **virtualization:** add virtualize prop ([#210](#210)) ([fad3f78](fad3f78))
@github-actions
Copy link

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant