Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cartpole angular_center_resolution and angular_outer_resolution in radians #25

Open
MuhammadSYahyaS opened this issue Nov 23, 2024 · 0 comments

Comments

@MuhammadSYahyaS
Copy link

Looking into cartpole_model.py:L45, the angle_range is defined in radians. Also, how the physics is simulated for calculating new velocity and new angular velocity are also using radians sin and cos functions.

However, the default parameter of angular_center_resolution=.1 and angular_outer_resolution=.5 made me perceiving it as in degrees, which can be a major issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant