Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conflicted pair method types values #204

Closed
ashrafyassin opened this issue Aug 5, 2020 · 1 comment
Closed

conflicted pair method types values #204

ashrafyassin opened this issue Aug 5, 2020 · 1 comment

Comments

@ashrafyassin
Copy link

I'm having issues pairing my accessory to the controller, it's seems that the pairing method is not supported by the accessory, while looking at the code i noticed a conflict in the values stated in file homekit/protocol/methods.py and the HAP-spec.
For example in HAP-spec, the PairSetup is 0, while in methods.py it is 1.

Screen Shot 2020-08-05 at 23 11 28

I dont know if the spec that i have is 100% accurate since it's Non-Commercial, can anyone confirm which values are the correct ones.

@Jc2k
Copy link
Collaborator

Jc2k commented Aug 5, 2020

#170 might help.

I think our constant is set based on an earlier version of the spec that predates soft auth (i.e. when all devices had an apple chip).

Some devices work if you pass 0, some work if you pass 1. There is no definitive documentation on which to use when. My theory was if the zeroconf data sets bit 1 on ff (the SupportsAppleAuthenticationCoprocessor flag) then it should be 1, otherwise it should be 0. But in practice it seems to be that iOS will pass 0 if no bits are set on ff, otherwise it will use 1.

There are some devices that seem to support neither scheme though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants