Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infrastructure/report test hangs and crashes #1

Closed
wants to merge 2,596 commits into from
Closed

infrastructure/report test hangs and crashes #1

wants to merge 2,596 commits into from

Conversation

jmarolf
Copy link
Owner

@jmarolf jmarolf commented Jan 31, 2022

  • Implement codefixes that reduce unnecessary allocation when empty collection required
  • Fix method names
  • Implement Prefer IsKind analyzer
  • CA1816 shouldn't warn for IAsyncDisposable.DisposeAsync
  • Add unit test
  • Try to fix unit test
  • Add IsAsyncDisposeImplementation helper
  • Update CallGCSuppressFinalizeCorrectly.cs
  • add missing using directive
  • Attempt to fix error
  • Update IMethodSymbolExtensions.cs
  • Attempt to fix
  • Update IMethodSymbolExtensions.cs
  • Update IMethodSymbolExtensions.cs
  • Check return type
  • Update IMethodSymbolExtensions.cs
  • Update IMethodSymbolExtensions.cs
  • Fix 'Default struct constructor missing from public API'
  • Convert RulesetToEditorConfigConverter to use top-level statements
  • Apply suggestions from code review
  • WIP
  • Update RS1024 to cover more comparisons
  • Handle enumerable methods
  • Add new descriptions
  • Remove empty line
  • Add VB test
  • Update IMethodSymbolExtensions.cs
  • Use .IsEmpty instead of .Length == 0
  • Update CallGCSuppressFinalizeCorrectlyTests.cs
  • Update excluded symbols API to prevent misuse
  • Remove unused directives
  • Update CA1810 to not report if there is an event subscription
  • Add codefix for CA1018
  • Update CallGCSuppressFinalizeCorrectlyTests.cs
  • Update CallGCSuppressFinalizeCorrectlyTests.cs
  • Update src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/MarkAttributesWithAttributeUsage.Fixer.cs
  • Apply suggestion
  • Refactor IsConfiguredToSkipAnalysis method signature
  • Refactor code and tests
  • Handle vbnet weird cases
  • Fix merge errors
  • Fix assert in presence of explicit cast of flow capture
  • updating arcade for rc1 so publish works
  • use latest sdk
  • Support for Property getter/setter and event add/remove annotations (Support for Property getter/setter and event add/remove annotations dotnet/roslyn-analyzers#4074)
  • build release branches
  • Update dependencies from https://github.com/dotnet/arcade build 20200903.7
  • Update dependencies from https://github.com/dotnet/arcade build 20200909.8
  • Update Versions.props
  • Some security analyzer tests
  • Some tests for true negatives
  • Remove extraneous line
  • CA5377 shouldn't warn when unable to get control flow graph
  • WIP
  • Fix other unit tests for 2.9.x
  • Update CA1051 to allow user-option to disable struct analysis
  • Clarify titles / messages
  • Address review feedback
  • Simplify code for CA2225
  • CA2225: array types for implicit and explicit conversions
  • Revert unwanted change
  • use pattern matching
  • fix spelling error
  • merging
  • use TryGetEnclosingControlFlowGraph api
  • Respect CodeAnalysisTreatWarningsAsErrors for IDE design-time builds
  • Update Versions.props
  • Update dependencies from https://github.com/dotnet/arcade build 20200917.6
  • Update CA1001 to display correct list of disposable fields
  • Store the global flow values per operation as a post-step
  • fixup merge
  • update msbuild
  • Fix test
  • Move other APIs
  • Remove unused using
  • Add more tests and fix asserts
  • Simplify tests and remove unused using
  • Revert unnecessary change
  • Update CA2248 to fix issues with generic enum types
  • Fix broken test
  • Remove unused using
  • Update CA2214 to handle local func
  • Update src/Utilities/Compiler/Extensions/ISymbolExtensions.cs
  • Fix DataflowOperationVisitor.VisitUnaryOperator
  • Fix incorrect merge
  • Move to newer MS.CA.Analyzer.Testing - require a bug fix for testing nested code actions
  • Fix resource string
  • Sort nested actions - this also ensures the most common fix 'AttributeTargets.All' shows up first
  • Update tests
  • Suppress false positive
  • Enable IDE0055 for vbnet
  • Move to latest CodeStyle package and fix violations
  • test v3
  • Refactor code to rely on CreateDiagnostic helper
  • Update documentation to mention use of the wildcard symbol
  • Simplify wildcard matching algorithm
  • Add more tests
  • Fix broken tests
  • Fix NRE in BasicDoNotUseCountWhenAnyCanBeUsedFixer (Fix NRE in BasicDoNotUseCountWhenAnyCanBeUsedFixer dotnet/roslyn-analyzers#3981)
  • Fix tests
  • Update CA1826 to add user option to exclude OrDefault methods
  • Handle expression-bodied method in code-fixes for RS1025 and RS1026
  • Trigger rebuild
  • Add null checks for access to ApplicationSyntaxReference
  • Update RS1008 to stop reporting on nested struct
  • Address review comments
  • Update Versions.props
  • Update src/Microsoft.CodeAnalysis.Analyzers/Core/MetaAnalyzers/DiagnosticAnalyzerCorrectnessAnalyzer.SyntaxNodeWithinAnalyzerTypeCompilationAnalyzer.cs
  • Address review comments
  • Remove unused using
  • Switch platform compat analyzer to do an optimistic flow analysis
  • Fix inconsistency bug, child cannot widen as support, can narrow (Fix inconsistency bug, child cannot widen as support, can narrow dotnet/roslyn-analyzers#4208)
  • Avoid maestro channel consistency check
  • Revert security related changes
  • Address review comment
  • Update ISymbol.IsReadOnly() to handle methods and types
  • Handle new syntaxes only when available
  • Create a separate codefix project
  • Address review comments
  • Update dependencies from https://github.com/dotnet/arcade build 20200924.4
  • Add RecordDeclaration to IsNamedTypeDeclarationBlock
  • Apply suggestions from code review
  • Add test for records in static holder analyzer
  • Update src/Microsoft.CodeAnalysis.Analyzers/CSharp/MetaAnalyzers/CSharpDiagnosticAnalyzerAPIUsageAnalyzer.cs
  • Apply suggestions from code review
  • Update StaticHolderTypeTests.cs
  • Address review comments
  • Fix formatting
  • Improve test coverage for RethrowToPreserveStackDetailsAnalyzer
  • Update CA1812 to handle types declared through DebuggerTypeProxy
  • Refactor attribute matching algorithm
  • Apply suggestions from code review
  • Remove MyGet feeds now that dependencies are published to AzDO (Remove MyGet feeds now that dependencies are published to AzDO dotnet/roslyn-analyzers#4245)
  • Rewrite RethrowToPreserveStackDetailsAnalyzer as operation analyzer
  • Remove unused using
  • Remove un-needed debug.assert
  • Update CA1062 to handle NotNullAttribute
  • Address review comments
  • CA1062: Add tests for is null or not null patterns
  • Update RS1010 to not report on overload with nestedActions
  • Remove duplicate tests
  • Address review comment
  • Address review comments
  • Upload coverage to codecov.io is flaky, so do not fail build on upload failure
  • CA1068: Allow caller attributes to come after cancellation token (CA1068: Allow caller attributes to come after cancellation token dotnet/roslyn-analyzers#4228)
  • Fix unspeakable main name
  • Update azure-pipelines.yml
  • Rename MicrosoftCodeAnalysisForShippedApisVersion to MicrosoftCodeAnalysisVersionForTests
  • Update Microsoft.CodeAnalysis.PublicApiAnalyzers.UnitTests.csproj
  • Update Roslyn.Diagnostics.Analyzers.UnitTests.csproj
  • Update Microsoft.CodeAnalysis.NetAnalyzers.UnitTests.csproj
  • Loc Checkin 9/30/2020
  • Remove conf entry disabling IDE0005_gen
  • Remove CA2213 suppression
  • Use WithArguments instead of WithMessage in unit test
  • Address feedback
  • Update DeclarePublicApiAnalyzerTests.cs
  • Refactor BannedAnalyzer tests to use markup and span instead of location
  • Ignore identity conversions in UseValueTasksCorrectly (Ignore identity conversions in UseValueTasksCorrectly dotnet/roslyn-analyzers#4274)
  • Fix bug when exception declared in filter is thrown
  • Fix to improve code fixer heuristic employed by CA1835 (Fix to improve code fixer heuristic employed by CA1835 dotnet/roslyn-analyzers#4269)
  • Apply suggestions from code review
  • Apply suggestion
  • Add test with private ctor with parameters
  • Simplify based on feedback
  • Add test without variable declarator in catch
  • Add both tests with WorkItem
  • Fix formatting
  • Fix various spelling errors
  • regenerate resource files
  • Update src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/DoNotRaiseExceptionsInUnexpectedLocations.cs
  • Update CA doc links to point to dotnet docs repo
  • Instruction for debugging analyzer with runtime repo projects (Instruction for debugging analyzer with runtime repo projects dotnet/roslyn-analyzers#4244)
  • Fix oblivious analysis of type parameters (Fix oblivious analysis of type parameters dotnet/roslyn-analyzers#4246)
  • use stable versions
  • Initial work for CI generated files validation
  • set stable package to false
  • Apply suggestions from code review
  • Add doc for resolving conflict with IVT
  • Continue analysis even RuntimeInformation, OSPlatofrm types not loaded (Continue analysis even RuntimeInformation, OSPlatofrm types not loaded dotnet/roslyn-analyzers#4281)
  • Update src/PerformanceSensitiveAnalyzers/PerformanceSensitiveAnalyzers.md
  • [release/5.0.1xx] Update dependencies from dotnet/arcade ([release/5.0.1xx] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#4300)
  • Address feedback
  • Make the normal build non-validation-only
  • Fix typo
  • Run on CI only and prefix the last option with -validateOnly:
  • Apply suggestions from code review
  • Apply PR feedback
  • Update the validation for RulesMissingDocumentation
  • Temporarily remove CI condition to check if there are failures
  • Skip validating files in artifacts
  • Don't call Validate(..) with files in artifacts
  • Update Program.cs
  • CI build only
  • Validate sarif files
  • Run pack on RoslynAnalyzers.sln
  • Run pack on FxCopAnalyzers.sln
  • textWriter.Flush();
  • Fix bug
  • Fix extra 'temp-' in printing
  • Remove more false positives from CA3075
  • CA1822: Add test for custom SkippableFactAttribute
  • Improve test coverage for RethrowToPreserveStackDetailsAnalyzer
  • Update RS1008 to stop reporting on nested struct
  • Update src/Microsoft.CodeAnalysis.Analyzers/Core/MetaAnalyzers/DiagnosticAnalyzerCorrectnessAnalyzer.SyntaxNodeWithinAnalyzerTypeCompilationAnalyzer.cs
  • Update ISymbol.IsReadOnly() to handle methods and types
  • Handle new syntaxes only when available
  • Remove MyGet feeds now that dependencies are published to AzDO (Remove MyGet feeds now that dependencies are published to AzDO dotnet/roslyn-analyzers#4245)
  • CA1062: Add tests for is null or not null patterns
  • Remove duplicate tests
  • Update CA1062 to handle NotNullAttribute
  • Address review comment
  • CA1068: Allow caller attributes to come after cancellation token (CA1068: Allow caller attributes to come after cancellation token dotnet/roslyn-analyzers#4228)
  • Rewrite RethrowToPreserveStackDetailsAnalyzer as operation analyzer
  • Remove unused using
  • Address review comments
  • Fix unspeakable main name
  • Rename MicrosoftCodeAnalysisForShippedApisVersion to MicrosoftCodeAnalysisVersionForTests
  • Update Microsoft.CodeAnalysis.PublicApiAnalyzers.UnitTests.csproj
  • Update Roslyn.Diagnostics.Analyzers.UnitTests.csproj
  • Update Microsoft.CodeAnalysis.NetAnalyzers.UnitTests.csproj
  • Upload coverage to codecov.io is flaky, so do not fail build on upload failure
  • Update azure-pipelines.yml
  • Remove conf entry disabling IDE0005_gen
  • Remove CA2213 suppression
  • Use WithArguments instead of WithMessage in unit test
  • Address feedback
  • Fix to improve code fixer heuristic employed by CA1835 (Fix to improve code fixer heuristic employed by CA1835 dotnet/roslyn-analyzers#4269)
  • Fix bug when exception declared in filter is thrown
  • Apply suggestions from code review
  • Simplify based on feedback
  • Add test without variable declarator in catch
  • Add both tests with WorkItem
  • Fix formatting
  • Refactor BannedAnalyzer tests to use markup and span instead of location
  • Loc Checkin 9/30/2020
  • Ignore identity conversions in UseValueTasksCorrectly (Ignore identity conversions in UseValueTasksCorrectly dotnet/roslyn-analyzers#4274)
  • Update RS1010 to not report on overload with nestedActions
  • Fix correct issue
  • RS1008: Add test for nested struct
  • Update dependencies from https://github.com/dotnet/arcade build 20201010.1 ([release/5.0.1xx] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#4311)
  • Switch to preview pool to unblock official build
  • Rename CA5379
  • Comment out unused code
  • Update src/NetAnalyzers/UnitTests/Microsoft.NetFramework.Analyzers/DoNotUseInsecureDtdProcessingXmlReaderCreateWrongOverloadTests.cs
  • Address review feedback
  • [release/5.0.1xx] Use non-open queue ([release/5.0.1xx] Use non-open queue dotnet/roslyn-analyzers#4315)
  • Run msbuild /t:pack against RoslynAnalyzers.sln and FxCopAnalyzers.sln
  • Update GuidelinesForNewRules.md
  • Try to investigate failures
  • Remove example issue
  • Small fix
  • Update NetCore_GettingStarted.md
  • Fix localization issue
  • [master] Update dependencies from dotnet/arcade ([master] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#4289)
  • Try to use en-US specifically
  • Fix localization bug
  • Update bug-report issue template for new docs link
  • Update rule-improvement issue template for new docs link
  • CA2243: Update the rule to exclude ObsoleteAttribute.UrlFormat
  • Address review feedback
  • Update docs link in release tracking analyzer
  • InvariantCulture
  • Punctuate
  • Fix more loc bugs with analyzer descriptions
  • Run msbuild /t:pack
  • Remove unneeded 'AnalyzerRulesetAssembly's
  • msbuild FxCopAnalyzers.sln /t:pack
  • Cleanup
  • Fix a typo
  • dummy commit
  • Revert "dummy commit"
  • Create PULL_REQUEST_TEMPLATE.md
  • Fix _RunOnCore property when running on .NET 5.0
  • Update .github/PULL_REQUEST_TEMPLATE.md
  • Update PULL_REQUEST_TEMPLATE.md
  • Update PULL_REQUEST_TEMPLATE.md
  • Update resx to use ASP.NET instead of ASP.Net
  • Run msbuild /t:pack
  • Update src/Directory.Build.targets
  • Fix markdownlint violations
  • Add markdownlint to CI
  • Fix generation process to follow markdownlint rules
  • msbuild pack after fixing generation process
  • Refactor CallSiteImplicitAllocationAnalyzer and fix bugs
  • Handle conditional access operator in CompareSymbolsCorrectlyFix
  • Add more tests
  • Update CallSiteImplicitAllocationAnalyzerTests.cs
  • Fix tests
  • Fix VB test
  • Remove explicit dependency on roslyn used to build This will remove the override of the version of roslyn used to build this repo
  • Add pragma suppression for nullable warning
  • Switch CA1805 from Info to Hidden based on user feedback
  • Add CompilationEnd custom tag to diagnostics reported in compilation end actions
  • Run pack to update documentation file
  • Remove unneeded not working code in targets file
  • Update comment for more clarity
  • Move comment
  • Update to Roslyn 3.8.0-4.final for testing
  • Add record tests to CreateTestAccessor refactoring
  • Handle one more special case in CA1508 IsNull bailout cases
  • Add CompilationEnd custom tag to diagnostics reported in compilation end actions
  • Run pack to update documentation file
  • Fix formatting
  • Fix formatting
  • Remove 'isReportedAtCompilationEnd: true' for compilation end analyzers ported to symbol start/end analyzers
  • Initial support for IForEachLoopOperation in DoNotCopyValue
  • Order APIs case-insensitive with case-sensitive fallback
  • Support foreach over parameters in DoNotCopyValue
  • Clean up 'foreach' handling to match invocation handling
  • Move language-specific functionality to derived types
  • Update definition of AnalyzerReleases.Shipped.md item to fix up-to-date check
  • Improve handling of values in DoNotCopyValue
  • Update Roslyn.Diagnostics.Analyzers to Microsoft.CodeAnalysis 3.7.0
  • Post release activities after 2.9.12 release
  • Add null check for AttributeConstructor
  • Post release activities after 3.3.1 release of analyzer packages
  • Implement TemporaryArrayAsRefAnalyzer
  • add devcontainer
  • Support 'nameof' operations
  • Fix support for ternary operations
  • Support using statements with no variable declaration
  • Fix handling of slice expressions that do not have an IOperation representation
  • Handle multiple analyses passes of the visitor
  • Add test
  • Update coverlet and codecov dependencies
  • Make the codecov upload optional
  • Always publish build logs
  • Simplify coverlet invocations
  • Use BeforeTargets instead of AfterTargets to ensure target runs
  • AvoidUninstantiatedInternalClasses: Don't report on static classes
  • Add IsStaticHolderType back
  • Update AvoidUninstantiatedInternalClassesTests.cs
  • Update the reflection based logic to respect no-location diagnostic severity configuration in editorconfig files
  • Use the method available in all projects in the solution
  • Refactor code
  • Add additional test and update the fix to be more defensive when CA1508 fires for IsNull operations in CFG
  • Add another test for filed bug
  • Make the bailout condition much more explicit
  • Fix another CA1508 issue (CA1508 should not warn on as expression dotnet/roslyn-analyzers#4411)
  • Fix workitem attribute
  • Fix CA1508 False positive on Nullable DateTime dotnet/roslyn-analyzers#4415 by properly handling unboxing to nullable value type
  • Handle OperationKind.None in value content analysis
  • Range/Index test should be NETCOREAPP only
  • Update CallSiteImplicitAllocationAnalyzer.cs
  • Update CA1001 to support excluded_symbol_names option
  • [master] Update dependencies from dotnet/arcade ([master] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#4343)
  • Flag when platform specific type used as generic type parameter (Flag when platform specific type used as generic type parameter dotnet/roslyn-analyzers#4403)
  • Update dependencies from https://github.com/dotnet/arcade build 20201110.3 ([release/5.0.2xx] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#4421)
  • Update dependencies from https://github.com/dotnet/arcade build 20201110.3 ([release/5.0.1xx] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#4422)
  • Enable building on Linux
  • Update README.md
  • Update VERSIONING.md
  • Change question mark to space
  • msbuild RoslynAnalyzers.sln /t:pack
  • msbuild FxCopAnalyzers.sln /t:pack
  • Fix msbuild command.
  • Avoid increasing accessibility for testing
  • Fixed typo
  • Fix predicate analysis for IsNullOrXXX method calls
  • Avoid populating _wildcardMatchResult on fast path
  • Fix ./build.sh --pack to work on Linux
  • Updating package upgrade message
  • Param array parameters can be null
  • Reduce rebuilding GenerateAnalyzerNuspec.csproj
  • Update the compiler to the 3.8.0 release
  • Remove AppHosts from tools
  • Update dependencies from https://github.com/dotnet/arcade build 20201111.5 ([master] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#4430)
  • Fix formatting and use top-level statements
  • Fix IDE0073: File header
  • Fix IDE0057: Use range operator
  • Fix nullable warning CS8600
  • Fix IDE0062: Make local function static
  • Fix CA1820: Test for empty strings using string length
  • Fix IDE0078: Use pattern matching
  • Update dependencies from https://github.com/dotnet/arcade build 20201117.7
  • Improve messaging for Platform Compat Analyzer (Improve messaging for Platform Compat Analyzer dotnet/roslyn-analyzers#4438)
  • bumping the version number to match 5.0.2 release
  • Update CA2227 to not report on init only property
  • Fix tests thanks to Youssef' feedback
  • CA2119: Fix false negative with extended interface
  • Update dependencies from https://github.com/dotnet/arcade build 20201123.2
  • Add deprecation warning to FxCopAnalyzers package
  • Also add the deprecation warning to bug-report.md issue template.
  • Update CA1068 to handle api_surface option
  • Fix RS1024: Do not report when SymbolEqualityComparer.Default is passed
  • Add one more test
  • Fix RS1024: Do not report on overloads not comparing symbols
  • Update src/Microsoft.CodeAnalysis.Analyzers/Core/MetaAnalyzers/CompareSymbolsCorrectlyAnalyzer.cs
  • Address review comments
  • Update configuration doc
  • Fix NRE in RS1024
  • Remove mock APIs used for PC analyzer as we can now use new APIs (Remove mock APIs used for PC analyzer as now we can use new APIs in 5.0 dotnet/roslyn-analyzers#4483)
  • Update Versions.props
  • Update auto-generated documentation file by running msbuild /t:pack
  • Update Program.cs
  • Harden InterproceduralAnalysisConfiguration to prevent null tree argument
  • Update Versions.props
  • Update auto-generated documentation file
  • Fix CA1801 false positive with inline records.
  • Add tests for implicit record
  • CA1068: allow excluded_symbol_names user option
  • Address review comments
  • Address review comments
  • Remove unused directives
  • Find tainted data parameter SyntaxNodes more robustly, and don't treat ASP.NET MVC Controller property setter parameters as tainted
  • PostRelease activities after release of new analyzer packages
  • Update .editorconfig
  • Remove FxCopAnalyzers.sln and related projects
  • Update .editorconfig
  • Fix build
  • Fix build
  • Remove unnecessary suppression
  • An article is needed since the word 'method' is there
  • Flows better and matches other messages when it's just a name and not quoted as code
  • Update eng/Versions.props
  • Update eng/Versions.props
  • Update configuration to reflect actual behavior
  • Update doc links in Analyzer Configuration.md
  • Update localized links in Analyzer Configuration.md
  • Make all links consistent to lower case
  • Update sarif files
  • Update dependencies from https://github.com/dotnet/arcade build 20201201.2
  • Fix link
  • Update docs/Analyzer Configuration.md
  • Fix hyperlinks
  • Apply suggestions from code review
  • Address feedback
  • Fix CA1307 and CA1310 to not report on IQueryable context.
  • Add another deprecation comment in README
  • Remove legacy rulesets
  • Merge GenerateGlobalAnalyzerConfigs.csproj into GenerateDocumentationAndConfigFiles.csproj
  • Apply suggestions from code review
  • Apply suggestions from code review
  • Address review feedback; filter methods by MethodKind.Ordinary
  • Update PR template to reflect the deletion of FxCopAnalyzers.sln
  • Fix remaining bugs
  • Remove rule CA1801 - replaced by IDE0060
  • Remove unused directive
  • Update .github/PULL_REQUEST_TEMPLATE.md
  • Apply @Evangelink suggestion
  • Add CA1801 to removed rules list
  • Fix md and sarif files
  • Fix and unify markdown usage in 'Analyzer Configuration.md'
  • Fix other display errors
  • Use backtick instead of single quotes
  • Fix wrong namespace
  • Improving the message of PreferIsEmptyOverCountMessage (CA1836): (Fixing grammer of & improving CA1836 messages. dotnet/roslyn-analyzers#4210)
  • Add support for parsing AnalysisLevelSuffix
  • Fix CA1802 to not report on nint and nuint
  • Address review comments
  • Support global options in Roslyn 3.7+
  • Fix false positive for generic type parameters without constraints
  • Add code fix
  • Fix CA1508 false positive with Activator.CreateInstance
  • Add support for category-specific AnalysisLevel properties
  • Loc Update
  • Fix nullability for SymbolNamesWithValueOption
  • Update ICategorizedAnalyzerConfigOptions for C# 9 syntax
  • IDE0100
  • CA1305
  • CA1725
  • Try to fix the multi-target issue
  • Fix tests
  • Fix closing parenthesis
  • Revert "Fix closing parenthesis"
  • Revert "Try to fix the multi-target issue"
  • Revert "CA1305"
  • Apply suggestions from code review
  • Update dependencies from https://github.com/dotnet/arcade build 20201130.4 ([release/5.0.1xx] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#4560)
  • Update dependencies from https://github.com/dotnet/arcade build 20201130.4 ([release/5.0.2xx] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#4561)
  • Address review feedback
  • Prevent use of language-specific symbols in language-agnostic layers
  • Update src/Tools/GenerateDocumentationAndConfigFiles/Program.cs
  • Implement CA1704 and some tests
  • Set correct analyzer in shipped file
  • IDE0090
  • Use pattern matching
  • IDE0100
  • trigger CI
  • Update dependencies from https://github.com/dotnet/arcade build 20201210.4
  • RS1024: fix false positive on object creation
  • Invert ifs to reduce nesting
  • Fix CA2119 to report only on correct interface members
  • Fix issue location for vbnet
  • Correctly fix the test
  • Fix the InsecureObjectGraphResult.GetDisplayString method
  • Remove second descriptor because of FP rate
  • CA1416 Do not warn for OS dependent messages for creating NotSupportedExceptions (CA1416 Do not warn for OS dependent messages for creating NotSupportedExceptions dotnet/roslyn-analyzers#4577)
  • Address review comment
  • Refactor implementation
  • Remove unused file
  • Fix formatting
  • Fix localization failure (Fix localization failure dotnet/roslyn-analyzers#4583)
  • add linux CI
  • use unix compatible paths in test helpers
  • remove tmp from path
  • fix test paths
  • normalize line endings in test strings
  • skips tests that are windows specific
  • add shell scripts for linux users
  • handle mixed newlines
  • newline test fix
  • use NormalizeLineEndings in all ImportingConstructorShouldBeObsoleteTests tests
  • use regex to normalize line endings
  • disable tests that are failing on linux
  • use windows only attribute
  • do not validate config files on linux
  • Revert unwanted changes
  • Invert ifs to reduce nesting
  • Fix CA2119 to report only on correct interface members
  • Fix issue location for vbnet
  • Correctly fix the test
  • Update sarif file
  • Remove workaround in AnalysisEntityFactory for a possible IOperation bug
  • Remove workaround for IPropertyReferenceExpressions in IAnonymousObjectCreationExpression
  • Use switch pattern
  • Discard can be removed
  • Fix compiler warnings
  • Remove stale TODO comment
  • Update src/NetAnalyzers/CSharp/AnalyzerReleases.Unshipped.md
  • Update test to supportPointsToAnalysisKind
  • Address review comments
  • Use helper method instead of local code
  • Rewrite DoNotUseInsecureDtdProcessingInApiDesignAnalyzer
  • Add WindowsOnlyFact to RS1031, RS1032 and RS1033 tests
  • Fix CA2016 message
  • Fix analyzer level + simplify conditions
  • Add API
  • Spelling
  • Follow MD033
  • Fix merge error
  • IDE0100
  • IDE0090
  • CA1725
  • CA1305
  • FIx merge errors
  • IDE0110
  • IDE0090
  • CA1711
  • CA1725
  • CA1024
  • IDE0066
  • CA1002
  • Fix wrongly removed pragma
  • Revert CA suppressions
  • Implement IdentifiersShouldNotContainUnderscoresFixer
  • Update auto-generated files
  • Update doc links
  • Rewrite DoNotUseInsecureXSLTScriptExecutionAnalyzer
  • Use helpers + use extension methods
  • Update src/Tools/GenerateDocumentationAndConfigFiles/Program.cs
  • Trigger CI
  • Update dependencies from https://github.com/dotnet/arcade build 20201216.18
  • Update CA1820 to not report on expression trees
  • Simplify helper method
  • Apply suggestions from code review
  • Added code fix for new path of execution
  • Update src/Tools/GenerateDocumentationAndConfigFiles/Program.cs
  • Fix minor bug from previous commit
  • Add single quotes around variable substitutions
  • Regenerate with Ubuntu
  • Simplify and add tests
  • Move dictionary into resources
  • Address review feedback
  • Start converting tests
  • Replace TestAdditionalDocument with private classes
  • Use named tuple instead
  • Fix error
  • Ban non-markupKey WithLocation overloads
  • Add suppressions
  • Finish enabling tests
  • Remove duplicate tests
  • Move remaining tests
  • Merge tests
  • Update to Microsoft.CodeAnalysis.Testing 1.0.1-beta1.20623.3
  • Set output kind through ProjectState.OutputKind
  • Create additional projects through SolutionState.AdditionalProjects
  • Exclude GetPinnableReference from CA1024 analysis
  • Skip GetPinnableReference only if returns by ref
  • Update GetPinnableReference tests
  • Add test for ref readonly
  • Handle ref readonly
  • Revert regex change
  • Update dependencies from https://github.com/dotnet/arcade build 20201221.12
  • Added a couple tests, made class sealed
  • Fix indentation
  • Small refactoring
  • CA1822: Do not report on awaitable-awaiter
  • CA1024: Do not report on awaitable-awaiter
  • Use expression body for properties and indexers
  • Remove some unused pragmas
  • Enforce IDE0090 and fix remaining issues
  • Fix various nullability warnings
  • Bring back suppression
  • Latest translations
  • Apply review comments
  • MarkMembersAsStatic: Add indexer test
  • MarkMembersAsStatic: Exclude indexers
  • Fix tests
  • Revert un-needed change
  • Add invalid code to see if it fails build
  • Update dependencies from https://github.com/dotnet/arcade build 20201230.2
  • Apply suggestions from code review
  • Revert "Add invalid code to see if it fails build"
  • Update Versions.props
  • Update auto-generated doc file
  • Update src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/TypeNamesShouldNotMatchNamespaces.cs
  • Update src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/TypeNamesShouldNotMatchNamespaces.cs
  • Apply feedback
  • VB Test
  • Fix style warning
  • Fix one more violation
  • Apply review comments
  • Post release activities for NetAnalyzers release 5.0.3
  • Workaround warning in Markdownlint job
  • Update src/NetAnalyzers/Core/Microsoft.NetFramework.Analyzers/Helpers/SecurityDiagnosticHelpers.cs
  • CA1416 improve call site messaging, fix bug related to MSBuild platform names casing (CA1416 improve call site messaging, fix bug related to MSBuild platform names casing dotnet/roslyn-analyzers#4608)
  • Update src/NetAnalyzers/Core/Microsoft.NetFramework.Analyzers/DoNotUseInsecureDtdProcessingInApiDesign.cs
  • Fix AnalyzerReleases.Unshipped.md
  • Remove single-file analyzer
  • Run pack
  • Avoid direct casts
  • Added PreferDictionaryContainsMethods Analyzer
  • Update dependencies from https://github.com/dotnet/arcade build 20210108.3
  • Update src/NetAnalyzers/Core/AnalyzerReleases.Unshipped.md
  • Illustrate unexpected oblivious on implicit containing type in public API (Illustrate unexpected oblivious on implicit containing type in public API dotnet/roslyn-analyzers#4681)
  • Refactored fixer into separate CS and VB implementations
  • Update src/NetAnalyzers/Core/Microsoft.NetFramework.Analyzers/DoNotUseInsecureXSLTScriptExecution.cs
  • Revert "Run pack" and "Fix AnalyzerReleases.Unshipped.md"
  • Run pack
  • Fixed warnings
  • Fixed merge conflicts, ran MSBuild
  • Address review feedback
  • Fix instances of RS0030: Use markupKey
  • Incorporate more feedback
  • Add link to issue in TODO
  • Update messages for Prefer IsKind analyzer
  • Implement analyzer with basic tests
  • [release/5.0.2xx] Update dependencies from dotnet/arcade ([release/5.0.2xx] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#4695)
  • Run a FixAll in solution for CA1725
  • Enable CA1725
  • CA1825: Bail-out for expression trees
  • use trycase instead of directcast in vb
  • Added more tests
  • Update dependencies from https://github.com/dotnet/arcade build 20210112.10
  • Add test: InstanceMemberUsedInXml_NoDiagnostic
  • Address PR feedback
  • Delete unneeded skipped tests
  • Update PublicAPI.Unshipped.txt
  • Update PublicAPI.Unshipped.txt
  • Ensure CA1835 preserves nullability (Ensure CA1835 preserves nullability dotnet/roslyn-analyzers#4664)
  • Update PublicAPI.Unshipped.txt
  • [release/5.0.1xx] Update dependencies from dotnet/arcade ([release/5.0.1xx] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#4694)
  • Revert workaround for old SyntaxGenerator bug
  • Fix references to fixer in tests
  • Make DefineAccessorForAttributeArguments language-agnostic
  • Make DoNotRaiseExceptionsInUnexpectedLocations language-agnostic
  • Fix outdated rule id in comments
  • Run pack
  • Make all rules warning for RulesetKind.AllEnabled
  • Update Program.cs
  • Make similar change for CustomTagEnabled and CategoryEnabled
  • Add ProvideStreamMemoryBasedAsyncOverrides analyzer
  • Forgot to MSBuild
  • Update src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/ProvideStreamMemoryBasedAsyncOverrides.cs
  • Fix crash bug on illegal code
  • Rerun CI
  • Apply suggested changes
  • Rerun CI
  • Forgot to msbuild /t:pack
  • Fix typo
  • Update dependencies from https://github.com/dotnet/arcade build 20210121.2
  • Add required files
  • manually remove myget packages
  • add newer testing version (old one was only on nuget)
  • do not warn about obsolete members in this branch
  • suppress "Type or member is obsolete" in code
  • Update .editorconfig
  • disable CS0618 at other test locations
  • Add new line back
  • Run msbuild /t:Pack
  • Remove redundant code
  • CA1802: Don't report diagnostic for preview feature constant interpolated strings
  • Fixup feeds
  • Fixup feeds
  • Fixup feeds
  • Fixup feeds
  • Fixup feeds
  • Bump log4net from 2.0.4 to 2.0.10 in /tools/FileIssues
  • Fix NRE in CA3076
  • Simplify code to use HasAttribute extension method
  • Common cases
  • Remove unnecessary usings
  • Remove workaround for fixed issue
  • Update dependencies from https://github.com/dotnet/arcade build 20210128.12
  • Apply suggestions from code review
  • CA1416 handle call-site empty sets causing warnings when TFM attributes applied (CA1416 handle call-site empty sets causing warnings when TFM attributes applied dotnet/roslyn-analyzers#4740)
  • Bump log4net from 2.0.4 to 2.0.10 in /tools/FileIssues
  • Add remarks about DIC
  • Use DiagnosticDescriptorHelper.Create
  • Unskip tests
  • Analyzer and fixer working
  • Update src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNetCoreAnalyzersResources.resx
  • Update src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNetCoreAnalyzersResources.resx
  • Don't report RS0027 if overload is obsolete
  • Apply the check for both RS0026 and RS0027
  • Fix end of line for public api fixes
    • Moved WalkDownImplicitConversionOnConcatOperand to the analyzer, and made it a static method. - Added tests for conditional substring invocation. We report conditional substring invocations, but do not fix them. - Fixed issue where Imports System was unnecessarily being added in projects that had System as an implicit global import, and added tests for VB projects with and without an implicit global System import. - Added null tests for both string and char type symbols, just in case. - Used exact values for expected iteration counts for nested violations tests. - Other minor style changes.
  • Fix tests on net472
  • Create a helper static class to avoid code duplication
  • Add tests
  • Fix 'testRunTitle' and 'Artifact Name' for Ubuntu jobs
  • Fix tests
  • Use Environment.NewLine
  • Fix usings order
  • Normalize multiline descriptions to \n in sarif files
  • Enable validation in Linux
  • Update src/PublicApiAnalyzers/UnitTests/DeclarePublicApiAnalyzerTests.cs
  • Rename the test accessor instance variable
  • Add artifacts produced from /t:pack
  • Fix CA1725
  • Test not reporting RS0026 on obsolete APIs
  • Add IsAssignableTo as extention method
  • WindowsOnlyFact -> Fact
  • Add build badges for Ubuntu
  • WindowsOnlyTheory -> Theory
  • Fix 'FormatLiteralValues' for consistent behavior across OSes
  • Implement 'Apply trait to class' refactoring
  • Clean up state and symbols
  • Apply formatter annotation
  • update versions
  • Fix conditional Substring and char literals
  • Indicate that info-level messages can remain (Indicate that info-level messages can remain dotnet/roslyn-analyzers#4790)
  • Remove unused using
  • update sarif file
  • Add files and resources
  • Update DefineAccessorsForAttributeArguments.cs
  • Update DoNotRaiseExceptionsInUnexpectedLocations.cs
  • Add basic tests
  • Non-copyable analysis for fields and auto-properties
  • Update dependencies from https://github.com/dotnet/arcade build 20210205.5
  • Add more tests
  • Introduce a base class for globalization analyzers
  • Inherit from AbstractGlobalizationDiagnosticAnalyzer
  • Tweak assertion
  • Fix CA1508 and indentation
  • Skip analyzers with no rules
  • Create test for checking globalization rules
  • Fix localization failure (Fix localization failure dotnet/roslyn-analyzers#4583)
  • Update the release analyzer fixer to add a blank line after headers
  • Small rewording on the PR issue template
  • Add fixer for RS0023
  • Analyze generated code for CA2100 and CA3147 security rules
  • Test auto generated code
  • Add test for auto generated code
  • Fix test
  • Apply suggestions from code review
  • Update .github/PULL_REQUEST_TEMPLATE.md
  • Remove features that were ported to Roslyn itself.
  • Pack
  • Report file loading exception messages with invariant culture
  • Comment out rule ids that're ported to roslyn
  • Fixer fixes all unambiguous cases
  • Add new resource key for CA2225 fixer
  • CA1054: better code fix title
  • Fix AD0001: Analyzer 'Microsoft.NetCore.Analyzers.Security.UseAutoValidateAntiforgeryToken' threw an exception of type 'System.ArgumentNullException' with message 'Value cannot be null.' dotnet/roslyn-analyzers#4772
  • Update dependencies from https://github.com/dotnet/arcade build 20210212.3 ([release/5.0.1xx] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#4843)
  • Update dependencies from https://github.com/dotnet/arcade build 20210212.3 ([release/5.0.2xx] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#4844)
  • Update latest pre-release link for Microsoft.CodeAnalysis.Analyzers
  • Handle incomplete cases
  • Fix superfluous System imports
  • Update dependencies from https://github.com/dotnet/arcade build 20210205.12
  • Delete test which is unrelated to the analyzer of interest
  • Delete unused resources
  • Add files
  • Loc update (Loc update dotnet/roslyn-analyzers#4805)
  • Address PR review
  • Add affirmative tests
  • More affirmative tests
  • CA5390: Consider byte array lengths before analysis
  • Apply suggestions from code review
  • Revert "Apply suggestions from code review"
  • One file left out from merge
  • Disable rules derived from SourceTriggeredTaintedDataAnalyzerBase
  • Disable CA1508 (AvoidDeadConditionalCode)
  • Disable CA2000 (DisposeObjectsBeforeLosingScope)
  • Fix typo in filename
  • Add no diagnostic tests
  • CA-1416 Disable generated code analysis (Disable generated code analysis for CA-1416  dotnet/roslyn-analyzers#4846)
  • Apply suggestions from code review
  • Address review feedback
  • Address review feedback
  • Update src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/MicrosoftCodeQualityAnalyzersResources.resx
  • Update resources
  • Add tests
  • Apply suggested changes
  • Apply suggested changes from other PR
  • Skip localized message comparison
  • Revert "Report file loading exception messages with invariant culture"
  • Apply suggestions from code review
  • Fix merge
  • Add note to bug-report template
  • minor adjustment
  • Apply suggested changes
  • Add original source for HashCode
  • Add origin notes
  • Update RoslynHashCode for use in roslyn-analyzers
  • Use RoslynHashCode for hash calculation
  • CA5360: Show potential invocations to reach potentially dangerous method
  • Apply suggested changes
  • Use SymbolEqualityComparer
  • Update Versions.props
  • Inline resource creation
  • Use parameter name 'context' consistently
  • Combine analyzer and code fix tests
  • Prefer code fix tests to analyzer tests
  • Verify diagnostic span instead of location
  • Cache hash sets for TaintedDataConfig
  • Avoid fast-path allocation in TryGetOrCreateTypeByMetadataName
  • Avoid static delegate allocations
  • Avoid predicate allocations in DataFlowOperationVisitor
  • Add lightup support for IUsingOperation.IsAsynchronous
  • Add lightup support for IUsingDeclarationOperation
  • Support 'await using' in CA2007 (DoNotDirectlyAwaitATask)
  • Dogfood PerformanceSensitiveAnalyzers instead of linking sources
  • Update to Microsoft.CodeAnalysis.Testing 1.0.1-beta1.21123.3
  • Add source generator for *.resx
  • Fix semantics of WalkUpParentheses and WalkUpConversion
  • Fix tests for OS with forward slash directory separator
  • Use a custom fix all provider for DoNotDirectlyAwaitATaskFixer
  • Add generic constraint
  • Update public api
  • CA-1418 Validate platform string (CA-1418 Validate platform string dotnet/roslyn-analyzers#4838)
  • Update PerformanceSensitiveAnalyzers and remove workaround
  • Avoid boxing values to call GetHashCodeOrDefault()
  • Apply changes to resources from code review
  • Remove dead code found by buyaa-n
  • Update dependencies from https://github.com/dotnet/arcade build 20210225.5
  • Update to Microsoft.CodeAnalysis.NetAnalyzers 5.0.4-preview1.21126.5
  • Add support for lambdas in taint analysis
  • Link suppressions to tracking issues
  • Bump code style package to 3.9.0
  • Apply suggestions from code review
  • Update to Microsoft.CodeAnalysis.Testing 1.0.1-beta1.21126.1
  • Update tests to use compiler support for .editorconfig
  • Update dogfood analyzers to 3.3.2
  • Update DesiredFileMissing_GetFile_ReturnsNull to work with Test Explorer
  • Add regression test for PlatformCompatabilityAnalyzer timely termination
  • Address review feedback
  • Reorder tests to minimize differences
  • Add main to triggers
  • Add main to triggers
  • Switch occurrences of master to main
  • Switch occurrences of master to main
  • Revert
  • Revert
  • Fix the global flow state analysis merge algorithm to handle duplicate value merge
  • Rename to context
  • Update src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/SpecifyIFormatProvider.cs
  • Update src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/SpecifyIFormatProvider.cs
  • IDE0047: FixAll
  • Fix formatting
  • IDE0090: FixAll
  • IDE0004: FixAll
  • IDE0078
  • Address feedback from Sam and Gen and also add couple more DFA short circuit checks to fix #51652
  • Add analyzers/fixers for Environment.ProcessPath and CurrentManagedThreadId (Add analyzers/fixers for Environment.ProcessPath and CurrentManagedThreadId dotnet/roslyn-analyzers#4909)
  • Address feedback from Sam
  • Fix the global flow state analysis merge algorithm to handle duplicate value merge
  • Address feedback from Sam and Gen and also add couple more DFA short circuit checks to fix #51652
  • Address feedback from Sam
  • Remove test that cannot be added in 5.0.2xx branch
  • Add mock attributes to test source in 5.0.2xx branch
  • Avoid fast-path allocations in TryGetOptionValue
  • Avoid ImmutableHashSet iteration on fast path
  • [release/5.0.2xx] Update dependencies from dotnet/arcade ([release/5.0.2xx] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#4937)
  • [release/5.0.1xx] Update dependencies from dotnet/arcade ([release/5.0.1xx] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#4938)
  • Rewrite PreferIsKindFix using DocumentBasedFixAllProvider
  • Create markdown-links-verifier.yml
  • Delete dead links
  • Delete markdown-links-verifier.yml
  • Add arcade-powered-source-build local and ci builds
  • Merge release/6.0.1xx-preview2 to release/6.0.1xx-preview3 (Merge release/6.0.1xx-preview2 to release/6.0.1xx-preview3 dotnet/roslyn-analyzers#4902)
  • Add test
  • Update SpecifyCultureInfoTests.cs
  • Handle condition access in PreferIsKind analyzer
  • Don't report on Nullable
  • Update PreferIsKindAnalyzer.cs
  • Update PreferIsKindAnalyzer.cs
  • Add OneLocBuild task
  • test
  • Add OneLocBuild to correct yaml
  • OSX is alias for MacOS (OSX is alias for MacOS dotnet/roslyn-analyzers#4952)
  • Update azure-pipelines.yml
  • allow us to test feature branches on signed builds
  • Loc update
  • Set ExcludeFromSourceBuild instead of patching the solution
  • Remove unused build properties
  • Remove unnecessary patches
  • Avoid depending on PerformanceSensitiveAnalyzers package for PerformanceSensitiveAttribute
  • Build private tools with net5.0
  • Clean up conditional warning suppressions
  • Apply patches directly to source
  • Exclude PublicApiAnalyzers and BannedApiAnalyzers from source build
  • Simplify code analysis configuration for source build
  • Use original package versions
  • Remove unnecessary version overrides
  • Simplify ExecutesDuringBuild configuration
  • Remove unnecessary source build customizations
  • Remove Microsoft.CodeAnalysis version override
  • Build private tools with net5.0
  • Remove unused build properties
  • Remove customized NoWarn property from source build
  • Update bug-report.md
  • Update Versions.props
  • Update new files to arcade latest
  • Update to Microsoft.CodeAnalysis 3.9.0 final for ResxSourceGenerator
  • Move Microsoft.CodeAnalysis.ResxSourceGenerator.Package to nuget folder
  • Fixes CA2016 ignores the return type of the method overloads dotnet/roslyn-analyzers#4985
  • allow diagnostic if return types are implicitly convertable to each other
  • special case Task and ValueTask conversions
  • simplify if
  • Update dependencies from https://github.com/dotnet/arcade build 20210329.7
  • update
  • Report a warning for APIs marked removed but are not removed
  • Add missed WorkItem
  • Don't allocate a list when the work can be done easily in the loop
  • Run pack
  • Handle open generics forwarded types in public api analyzers
  • Add another test
  • Better fix
  • Fix failing test
  • Clean up verifiers for ResxSourceGenerator
  • Simplify application of compilation and parse options
  • Update to Microsoft.CodeAnalysis.Testing 1.0.1-beta1.21202.2
  • do not warn about analyzer version
  • install 5.0 runtime
  • use .NET 6 to resolve source build issues
  • use .NET 6
  • stop using depricated APIs
  • use IsAssignableTo helper
  • Update dependencies from https://github.com/dotnet/arcade build 20210403.1
  • adding VB tests
  • Update SmallDictionary from dotnet/roslyn
  • Revert "IDE0078"
  • Set IDE0078 to silent
  • Fix compile error
  • Fix CA1834
  • Update required VS version in README
  • Enable strict mode
  • Remove unsupported attribute when allow deny list mixed (CA1416 Remove unsupported attribute when allow deny list mixed dotnet/roslyn-analyzers#5000)
  • Update dependencies from https://github.com/dotnet/arcade build 20210409.17
  • OSX needs to treated as the same platform as MacOS, everywhere (OSX needs to treated as the same platform as MacOS, everywhere dotnet/roslyn-analyzers#5012)
  • Update dependencies from https://github.com/dotnet/arcade build 20210310.3 ([release/5.0.2xx] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#5016)
  • Address feedback
  • Fix test
  • Update MarkMembersAsStatic.cs
  • Address feedback
  • Update MarkMembersAsStatic.cs
  • Update Versions.props
  • Add a table of packages to the README file
  • remove unused resource strings
  • update translation
  • fixup
  • make xliff tasks happy
  • Add CSharp analyzer and tests
  • Add VB analyzer and tests
  • Fix WaitAll message and title
  • Add code fix and tests
  • Add unfixed cases to tests
  • Run msbuild /t:pack /v:m
  • Format
  • Add assert
  • Apply suggestions from code review
  • Update xlf files
  • Remove need for language specific syntax in analyzer
  • Move to performance instead of usage
  • Change to CA1839 and CA1840
  • Fix IsSingleTaskArgument
  • Change diagnostic id after rebase
  • PR feedback
    • Apply requested changes - Rename CSharpDictionaryContainsMethodsFixer.cs and BasicDictionaryContainsMethodsFixer.vb to be more consistent with other fixer file names
  • Run msbuild
  • Fix resx tag garbled in merge.
  • Include AnalyzerReleases in markdownlint
  • Run markdownlint -f to fix violations
  • Disable MD024: Multiple headings with the same content
  • writing up proposal
  • Update docs/performance/proposal.md
  • Update docs/performance/proposal.md
  • Update docs/performance/proposal.md
  • Update docs/performance/proposal.md
  • Update docs/performance/proposal.md
  • Update docs/performance/proposal.md
  • Update docs/performance/proposal.md
  • fix markdown warnings
  • fixup markdown spacing for lists
  • Update dependencies from https://github.com/dotnet/arcade build 20210419.2 ([release/6.0.1xx-preview4] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#5039)
  • Update src/NetAnalyzers/Core/AnalyzerReleases.Unshipped.md
  • Change doc link to ca1841
  • Apply requested changes
  • Add newline to end of resx file
  • Add newline character
  • CA1416 fix ambiguity in Version comparison (CA1416 Fix Version comparison ambiguity dotnet/roslyn-analyzers#4943)
  • explicitly specify which packages are shipping
  • Fix garbled unshipped.md markup
  • ship additional packages
  • Add rules back to AnalyzerReleases.Unshipped
  • Fix spacing in test
  • iconUrl -> icon
  • Update src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Tasks/DoNotUseWhenAllOrWaitAllWithSingleArgument.cs
  • Update description wording
  • Updated documentation based on description
  • Fix GetHashCode to only care about instances of ISymbol. Report on System.HashCode.Combine(ISymbol) usage
  • Add test case for 4956
  • Cleanup DoNotUseWhenAllOrWaitAllWithSingleArgument
  • Another approach
  • Remove dead condition
  • Refactor UseNameofInPlaceOfString
  • Update UseNameofInPlaceOfString.cs
  • Update UseNameofInPlaceOfString.cs
  • Change ID to CA1844
  • Fix failing CA
  • Correctly give higher priority to user's suffix map
  • fixup bad merge
  • Apply formatting changes
  • PR feedback
  • Update IdentifiersShouldHaveCorrectSuffixTests.cs
  • Use AnalyzerConfigFiles instead of AnalyzerConfigDocument
  • Fix nullable warning
  • Fix some tests
  • Parallel VB changes
  • Cleanup ReviewUnusedParametersTests
  • Delete EditorConfigParser
  • Update AnalyzerOptionsExtensions.cs
  • Don't propagate the now-unneeded CancellationToken
  • Apply requested changes
  • Update EnumsShouldHavePluralNames.cs
  • Change ID to CA1845
  • Fix
  • Attempt to move conditional compilation up and some cleanup
  • CODEANALYSIS_V3_OR_BETTER
  • Fix
  • Fix doc comment
  • .
  • Rebuild xlf files to fix CI
  • Fix incorrect removal of implicit property from PublicApi
  • Update PR suggestion
  • Add analyzer and code fixer for providing a public parameterless SafeHandle constructor.
  • Fill in the rest of the unit tests.
  • Undo accidental file rename.
  • PR feedback.
  • Update src/NetAnalyzers/Core/AnalyzerReleases.Unshipped.md
  • Coalesce fixer types.
  • Use alternative diagnostic location format.
  • Apply suggestions from code review
  • Fix resources based on feedback.
  • Remove extra parameter that seems unneeded.
  • Regenerate generated files.
  • Remove periods.
  • Fail if the file is defined as an additional file, but the content is empty
  • Update xlf
  • additionalText.GetText(cancellationToken); returns null, not an object with no Lines
  • Don't use PooledSortedSet that differ by compilations
  • Update eng/GenerateAnalyzerNuspec.targets
  • Update Directory.Build.props
  • Revert
  • $CommonFileElements$
  • Add additional test with larger inheritance tree.
  • Add localization from OneLocBuild (2021-04-27)
  • Move to Ubuntu 18.04 queue (Move to Ubuntu 18.04 queue dotnet/roslyn-analyzers#5075)
  • Merge conflicts (CA1416 Fix Version comparison ambiguity dotnet/roslyn-analyzers#5079)
  • Add localization from OneLocBuild (2021-04-28)
  • Change ID to CA1846
  • Rebuild resource files
  • Fix CI
  • .
  • Force xlf update
  • Import System namespace correctly
  • Allow affirmative checks with else-clause
  • Add VB test
  • Merge main to release/6.0.1xx (Merge main to release/6.0.1xx dotnet/roslyn-analyzers#5090)
  • [main] Update dependencies from dotnet/arcade ([main] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#5083)
  • Update dependencies from https://github.com/dotnet/arcade build 20210511.6
  • Use dotnet certificate (Use dotnet certificate dotnet/roslyn-analyzers#5096)
  • CA1416 Support custom guard members annotated with guard attributes (CA1416 Support custom guard members annotated with guard attributes dotnet/roslyn-analyzers#5087)
  • Use specific reference assemblies
  • Fix reference assemblies to be similar to the default, but only NetCoreApp
  • Add test with multiple interfaces (only one is overridden)
  • Preserve trivia
  • Fix CI
  • Add shared attribute to fixer
  • Add .NET Core taint tracking
  • Add unit tests for different sink kinds
  • Update dependencies from https://github.com/dotnet/arcade build 20210514.2
  • Fix links
  • Update src/NetAnalyzers/UnitTests/Microsoft.NetCore.Analyzers/Publish/AvoidAssemblyLocationInSingleFileTests.cs
  • Update src/NetAnalyzers/UnitTests/Microsoft.CodeQuality.Analyzers/Maintainability/ReviewUnusedParametersTests.cs
  • Update ReviewUnusedParametersTests.cs
  • Update MarkMembersAsStaticTests.cs
  • Update ValidateArgumentsOfPublicMethodsTests.cs
  • Update AvoidAssemblyLocationInSingleFileTests.cs
  • Update DisposableFieldsShouldBeDisposedTests.cs
  • Update ReviewUnusedParametersTests.cs
  • Update DisposeObjectsBeforeLosingScopeTests.cs
  • Update DoNotPassLiteralsAsLocalizedParametersTests.cs
  • Update SpecifyCultureInfoTests.cs
  • Update DeclarePublicApiAnalyzerTests.cs
  • Apply suggested changes
  • Update src/NetAnalyzers/Core/AnalyzerReleases.Unshipped.md
  • Fix Potential false negative in CA1047 dotnet/roslyn-analyzers#5025
  • Add failing tests
  • Fix casing errors in PreferStreamAsyncMemoryOverloads
  • Fix incorrect text comparisons
  • Add failing tests
  • Fix SpecifyMarshalingForPInvokeStringArguments
  • Add tests
  • Add checks for comparison operators
  • Apply suggested changes
  • Update src/NetAnalyzers/Core/AnalyzerReleases.Unshipped.md
  • Update src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/UseCancellationTokenThrowIfCancellationRequested.cs
  • Simplify fixer
  • Fix copy-paste error in unit test
  • Add failing tests
  • Fix false positive on nullable invariant types
  • Simplify analyzer
  • Fix lint error
  • Create files and tests
  • Use simple names in diagnostic messages
  • Update src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNetCoreAnalyzersResources.resx
  • Apply suggested changes
  • Run msbuild to fix CI
  • Implement analyzer and fixer
  • Run msbuild
  • Fix build warnings
  • Fix more build warnings
  • Apply suggested changes
  • Restructure analyzer and fixer
  • Run msbuild
  • Update Versions.props
  • Apply suggestions from code review
  • Apply suggested changes
  • Change diagnostic id to CA2251
  • rename file
  • Fix SonarQube's "IEnumerable LINQs should be simplified" / Code Smell
  • Fix ReSharper's "MergeSequentialChecks"
  • Fix ReSharper's "UseNullPropagation"
  • Sketch out the IDIC analyzer and "implement interfaces" code fixer.
  • Don't access the semantic model directly inside RegisterCodeFixesAsync.
  • Add codefix for the "must be sealed" case and add diagnostic for trying to write an implementation in VB (which is impossible to do correctly).
  • Use string.Empty instead of null
  • Apply suggested changes
  • Assert if symbols can't be loaded in fixer
  • Implement testing for DICImpl for the methods cases.
  • Work around CSharpSyntaxGenerator does not support adding interface members with a default implementation dotnet/roslyn#53605
  • Tiny Refactoring CA1824
  • Move TryCheckNeturalResourcesLanguageAttribute to compilation start
  • Fix formatting
  • Address feedback
  • Update Analyzer Configuration.md
  • Update docs/Analyzer Configuration.md
  • Update dependencies from https://github.com/dotnet/arcade build 20210521.3
  • Add support and testing for the properties, indexers, and events use cases.
  • Generated file changes.
  • Remove unused using.
  • PR Feedback.
  • Add support for init accessors in the code fix.
  • Fix more resources.
  • No CA1822 diagnostic if attribute implements NUnit's ITestBuilder
  • Remove redundant checks for types that implement ITestBuilder
  • Remove unnecessary string interpolation
  • Regenerate generated files on pack
  • Update src/NetAnalyzers/UnitTests/Microsoft.CodeQuality.Analyzers/QualityGuidelines/MarkMembersAsStaticTests.cs
  • [CA1416] Targeted build attributes can be overriden in cross platform assemblies ([CA1416] Targeted build attributes can be overriden in cross platform assemblies dotnet/roslyn-analyzers#5117)
  • Implement CA1847 - Use string.Contains(char) whenever possible
  • Update dependencies from https://github.com/dotnet/arcade build 20210512.2
  • Fix CA2247 handling of base(TaskContinuationOptions)
  • Add source build leg to official build
  • Update Versions.props
  • Update Versions.props
  • Loc/zh-hans: 过载 -> 重载
  • [main] Update dependencies from dotnet/arcade ([main] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#5137)
  • Turn on loc PRs
  • adding performance tests
  • use common versions
  • remove unused using
  • use constants
  • Combine to a single project and make some minor changes
  • do not pack test utilities
  • adding scripts to easily run and compare results
  • Fix CA1822 false positive with partial methods
  • Add the second workitem
  • Update src/NetAnalyzers/UnitTests/Microsoft.CodeQuality.Analyzers/QualityGuidelines/MarkMembersAsStaticTests.Fixer.cs
  • Address feedback
  • Add test for ??= operator
  • Remove un-needed blank line
  • Address feedback
  • Fix callers
  • Fix more callers
  • Fix IDE0005
  • Update PublicAPI.Unshipped.txt
  • Fix issue resulted from fixall
  • Revert "Fix issue resulted from fixall"
  • Revert "Fix IDE0005"
  • IDE0005 FixAll for project instead of solution
  • Fix detection of duplicate symbols with oblivious markers (Fix detection of duplicate symbols with oblivious markers dotnet/roslyn-analyzers#5141)
  • PR feedback.
  • fixup merge conflicts
  • fixing errors given by the test framework about editorconfig files being additional files
  • small script fixes
  • adding yaml file
  • throw exception on failed run
  • only fail on script error
  • add return code logging
  • update baseline for 6.0.x
  • [main] Update dependencies from dotnet/arcade ([main] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#5179)
  • Update dependencies from https://github.com/dotnet/arcade build 20210628.3
  • Escape asterisks when generating markdown doc files
  • Prevent CA2016 fixer from removing generic type parameter (Fix CA2016 when used on instance method with generic types dotnet/roslyn-analyzers#4974)
  • Analyzer to detect RequiresPreviewFeatures attribute (Analyzer to detect RequiresPreviewFeatures attribute dotnet/roslyn-analyzers#5155)
  • Allow multiple input files for SymbolIsBannedAnalyzer
  • Document multiple input files for SymbolIsBannedAnalyzer
  • Update Microsoft.CodeAnalysis.Testing to 1.1.1-beta1.21351.1
  • Fix concurrency issue in CA1069 analyzer (Fix concurrency issue in CA1069 analyzer dotnet/roslyn-analyzers#5243)
  • General cleanup
  • Update ISymbolExtensions.cs
  • Restore wellknown type
  • Fix
  • Fix
  • Address feedback
  • Update src/Utilities/Compiler/Extensions/ISymbolExtensions.cs
  • Update UseNameofInPlaceOfString.cs
  • Delete IDE dispose analyzer rules
  • Update CI error message for validating documentation and config files
  • Remove dead code in CA1069 analyzer (Remove dead code in CA1069 analyzer dotnet/roslyn-analyzers#5253)
  • readme sub badges
  • radme sub badges
  • Initial add of richnav indexing
  • Update yml spacing
  • Remove unauthorized settings
  • Update pool
  • Merge if with outer if
  • Update MicrosoftCodeAnalysisVersionForTests to 4.0.0-2.final
  • Add Net60 reference assemblies for tests
  • Update TestPreviewLanguageFeatures for new functionality
  • Simplify linq expressions
  • Remove some empty statements
  • Attempt to fix test step in build pipeline
  • Add richnav nuget source
  • RichNav run worked in main yml -- removing from there and copying it to richnav solo yml
  • Remove added whitespace
  • Remove unused vars, rename displayName for clarity
  • allow sub elements in markdown
  • Update Versions.props
  • Make known tags readonly
  • Install vs-threading analyzers
  • Fix VSTHRD200 (Use "Async" suffix for async methods)
  • Update RelaxTestNamingSuppressor to recognize BenchmarkAttribute
  • Suppress VSTHRD200 on benchmark methods
  • Add missing FactAttribute
  • Fix VSTHRD103 (Call async methods when in an async method)
  • Clarify that RuleLevel.BuildError is only valid for source generators
  • Code style feedback.
  • Better constrained AssociatedSymbol.
  • move to mit license
  • Only handle making the parameterless constructor public for the SafeHandle analyzer.
  • Fix TODOs and update unit tests with diagnostics (Fix TODOs and update unit tests with diagnostics dotnet/roslyn-analyzers#5287)
  • Add Logging Analyzer
  • Convert to IOperation analysis
  • Updated tests based on refactor
  • minor code cleanup
  • PR feedback
  • Use CreateDiagnostic extension method
  • update auto generated files
  • Fix "Run markdownlint" error
  • isPortedFxCopRule set false by default
  • isReportedAtCompilationEnd set to false
  • Rename test class to match file name
  • Update INameOfOperation handling to use correct constant value
  • Update IOperation to understand params arguments
  • move analyzer from csharp to core
  • Apply API review feedback.
  • narrow down scope of 4th diagnostic to LogTrace and friends
  • updating messages to become a bit more clear
  • Apply nit feedback
  • Ensure double cast in int-int division
  • Fix copy-paste error in Debug.Assert
  • Remove un-needed interface declaration
  • nit feedback
  • if to else if
  • rename: named hole -> named placeholder
  • fix paranthesis issue
  • do not update the label
  • Update analyzer/code-fix to convert all instance methods to statics (and require manual intervention on properties and events) since even in the sealed case, there are scenarios where Roslyn emits callvirt to sealed or private instance members.
  • update headers
  • Add test for usage rewriting.
  • Fix tests
  • Add more scenarios into CA1416 regression test
  • Add some more tests of the code fix.
  • Add no-op test for static-method requirement.
  • keep preview7
  • Refactor or conditions in DoNotUseInsecureDtdProcessingAnalyzer
  • Refactor tests to use non-obselete location API
  • Update DiagnosticCategoryAndIdRanges.txt
  • Update ProvidePublicParameterlessSafeHandleConstructor.Fixer.cs
  • handle params array in the argument list
  • Update src/NetAnalyzers/UnitTests/Microsoft.NetCore.Analyzers/Runtime/ForwardCancellationTokenToInvocationsTests.cs
  • remove unused parameters
  • rename types
  • rename files
  • manually contruct array in VB case
  • remove unused using
  • remove blank line
  • Update src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/ForwardCancellationTokenToInvocations.Fixer.cs
  • fixing formatting
  • update headers
  • use preview language version
  • prefer is not null to is object
  • fixup rebase
  • Move ExportCodeFixProvider attribute onto the concrete type
  • Remove half-checked-in submodule.
  • Unit tests for porting
  • Analyzer changes
  • Update dependencies from https://github.com/dotnet/arcade build 20210727.1
  • Update dependencies from https://github.com/dotnet/arcade build 20210729.2
  • Update docs on how to record removed API
  • fixup! Update docs on how to record removed API
  • Address feedback
  • [refactor] test's location
  • [delete] Test's api GetCSharpResultAt(int line, int startColumn, int endColumn, DiagnosticDescriptor descriptor, string bannedMemberName, string message) GetBasicResultAt(int line, int startColumn, int endColumn, DiagnosticDescriptor descriptor, string bannedMemberName, string message)
  • Update src/Microsoft.CodeAnalysis.BannedApiAnalyzers/UnitTests/SymbolIsBannedAnalyzerTests.cs
  • [fix] code style
  • CA1416 MacCatalyst is a superset of iOS (CA1416 MacCatalyst is a superset of iOS dotnet/roslyn-analyzers#5266)
  • Update IsTopLevelStatementsEntryPointMethod
  • Update IsTopLevelStatementsEntryPointMethod
  • Set analyzers global_level to -99/-100.
  • Implement the ModuleInitializerAttributeShouldNotBeUsedInLibraries analyzer (Implement the ModuleInitializerAttributeShouldNotBeUsedInLibraries analyzer dotnet/roslyn-analyzers#5347)
  • Remove unneeded Shared attribute
  • replace bitwise operator to boolean
  • Update src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/ApiDesignGuidelines/MarkAssembliesWithComVisible.cs
  • Update dependencies from https://github.com/dotnet/arcade build 20210809.4
  • use rc1
  • Add async analyzer
  • msbuild
  • Minor fix
  • Buffer.BlockCopy Analyzer (Buffer.BlockCopy Analyzer dotnet/roslyn-analyzers#5242)
  • Provide more flexibility in the SafeHandle constructor analyzer's visibility detection (Provide more flexibility in the SafeHandle constructor analyzer's visibility detection dotnet/roslyn-analyzers#5239)
  • Check for netcore tests
  • Remove JTF and IVs methods
  • Checkpoint.
  • sq
  • sq
  • Address comments
  • Add support for Boolean type (CA2018: Do not throw a diagnostic for Boolean arrays dotnet/roslyn-analyzers#5373)
  • Add support for CA1305 suppression.
  • [delete] unused using directive
  • [BannedApiAnalyzers] Added a function to warn the Analyzer when a prohibited class is specified in the argument of typeof() and test case.
  • [fix] code style
  • rebaseline release/6.0.1xx branch
  • Fixes exception on LoggerMessageAnalyzer for missing named placeholder
  • Apply PR feedback
  • fixup header
  • fixup Async Suffix warnings
  • fix yaml formatting
  • ensure repo is always restored
  • fixup number of expected diagnostics
  • Address comments and split tests into files
  • sq
  • Update Versions.props
  • use powershell task
  • use baseline with test fix
  • fixup analyzer warnings
  • Support for detecting preview-ness in dependencies (Support for detecting preview-ness in dependencies dotnet/roslyn-analyzers#5395)
  • Update MSBuild version comparison logic
  • Update versions.props source build behavior
  • Add offline validation to GenerateDocumentationAndConfigFiles for source build
  • Exclude PerformanceTests from source build
  • Refactor to get types at compilation start
  • Update build files
  • Refactor getTypes method
  • Reduce .cctor IL size in Microsoft.CodeAnalysis.Analyzers
  • Reduce .cctor IL size in Microsoft.CodeAnalysis.BannedApiAnalyzers
  • Reduce .cctor IL size in Microsoft.CodeAnalysis.CSharp.Analyzers
  • Reduce .cctor IL size in Microsoft.CodeAnalysis.PerformanceSensitiveAnalyzers
  • Fix headers
  • Reduce .cctor IL size in Microsoft.CodeAnalysis.CSharp.PerformanceSensitiveAnalyzers
  • Update NetCore_GettingStarted.md
  • Reduce .cctor IL size in Microsoft.CodeAnalysis.NetAnalyzers
  • Reduce .cctor IL size in Microsoft.CodeAnalysis.PublicApiAnalyzers
  • Reduce .cctor IL size in Microsoft.CodeAnalysis.VisualBasic.NetAnalyzers
  • Reduce .cctor IL size in Microsoft.Diagnostics.Analyzers
  • Reduce .cctor IL size in Microsoft.Diagnostics.CSharp.Analyzers
  • Reduce .cctor IL size in Microsoft.Diagnostics.VisualBasic.Analyzers
  • Reduce .cctor IL size in Text.Analyzers
  • Use cached diagnostic tags array
  • Clean up a few more static fields
  • Use read-only property for SupportedDiagnostics rather than computed property
  • Use read-only property for FixableDiagnosticIds rather than computed property
  • Fix extra blank line in NetCore_GettingStarted.md
  • Clarify that BuildError may be used with director approval
  • Check symbol is null before adding to list
  • Improve return type checks
  • Add analyzers for Microsoft.IdentityModel.Tokens (Wilson) Security Issues
  • Better diagnostic location for types (Better diagnostic location for types dotnet/roslyn-analyzers#5402)
  • Ensure the paths are case-sensitive
  • use lower case for file name
  • Merge PublicAPI from multiple sources
  • Add additional test case
  • Better diagnostic location for types
  • Address comments
  • Support for types extending base preview types
  • Add support for various diagnostic locations. Tests pass
  • Refactor and VB stubs
  • update markdown to use version 6
  • Self review
  • Mark analysis level 6 rules as shipped
  • adding required variable groups
  • Address comments and remove unused code
  • incorporating PR feedback
  • Add default case for switch statement in DoNotAlwaysSkipTokenValidationInDelegates
  • increase noise threshold to 35% to reduce probability of a false positive
  • Update xlf files after updating rule text to sentence casing.
  • Make methods abstract
  • only allocate ImmutableArray once in codefixers
  • Do not use static fields for resources only used in one place
  • Minor cleanup, changing readonly array to immutable to better match intent.
  • Support NullableTypeSyntax nodes in the location detection
  • Update Versions.props
  • Better diagnostic location for generic preview types
  • Clarify instructions for running msbuild /t:Pack (Clarify instructions for running msbuild /t:Pack dotnet/roslyn-analyzers#5396)
  • Localized file check-in by OneLocBuild Task
  • Remove braces (Add support for CA1305 suppression. dotnet/roslyn-analyzers#5374 (comment) + Add support for CA1305 suppression. dotnet/roslyn-analyzers#5374 (comment))
  • Remove ToList calls that seem superfluous.
  • Update tests.
  • Fix formatting.
  • Again.
  • Test for UICulture.
    • Update resx strings per feedback * Fix nullref exception found during, added unit test
  • fixed typo in src/NetAnalyzers/Core/AnalyzerReleases.Shipped.md
  • Remove dead code from DoNotAlwaysSkipTokenValidationInDelegates
  • Update dependencies from https://github.com/dotnet/arcade build 20210827.7
  • run msbuild /t:pack
  • fixup file headers
  • ensure tests follow rules for repo
  • use correct winforms references
  • Add analyzers for Microsoft.IdentityModel.Tokens (Wilson) Security Issues
  • incorporating PR feedback
  • Update xlf files after updating rule text to sentence casing.
  • Minor cleanup, changing readonly array to immutable to better match intent.
    • Update resx strings per feedback * Fix nullref exception found during, added unit test
  • update file headers
  • fixup tests to match repo requirements
  • fix typo
  • update docs files
  • Exclude test projects from source-build
  • Make CA2252 an error
  • msbuild pack
  • Update severity, apply last comment
  • fixup final newline
  • Remove unnecessary using directive
  • Apply more comments
  • Fix crash when querying auto properties (Fix crash when querying auto properties dotnet/roslyn-analyzers#5470)
  • Remove unused code and some refactoring
  • Fix bad merging
  • Apply more comments
  • Remove Eula.rtf from NuGet packages
  • Skipping CA2254 diagnostic when message template references constant values
  • [Code Metrics] Add quotes to project and out argument
  • Update src/Test.Utilities/AdditionalMetadataReferences.cs
  • Fix RuntimeInformaiton.IsOSPlatform(OSPlatform.OSX) guard
  • Update IMethodSymbolExtensions.cs
  • update branding
    • Apply PR feedback - Add test ignoring CA2254 with contant values in template
  • Remove unused switch cases
  • Localized file check-in by OneLocBuild Task
  • Skipping CA2254 diagnostic when message template references constant values
    • Apply PR feedback - Add test ignoring CA2254 with contant values in template
  • Remove unused switch cases
  • Add support for CA1305 suppression.
  • Remove braces (Add support for CA1305 suppression. dotnet/roslyn-analyzers#5374 (comment) + Add support for CA1305 suppression. dotnet/roslyn-analyzers#5374 (comment))
  • Remove ToList calls that seem superfluous.
  • Update tests.
  • Fix formatting.
  • Again.
  • Test for UICulture.
  • Test handling of duplicate symbols over multiple files in SymbolIsBannedAnalyzer
  • Fix false positive for calling virtual member of other instance
  • Update messages for symbol comparison diagnostic and codefix
  • Use ' instead of
  • Run msbuild /t:pack
  • Update NetCore_GettingStarted.md
  • Add milestone tracking automation (mutation disabled)
  • Fix expected repository name
  • Pass GITHUB_TOKEN to automation workflow
  • Update permissions and fix milestone JSON query
  • Enable release tracking
  • Fix escaping for MILESTONE_NAME and conditionally assign milestone
  • update required SDK
  • update arcade version
  • Update trigger event, permissions, and result
  • update compiler version
  • silence new IDE analysis
  • Enable auto-merge for OneLoc pull requests
  • Fix pull request author reference
  • Fix permissions for enablePullRequestAutoMerge mutation
  • update baselines
  • Label community pull requests
  • Localized file check-in by OneLocBuild Task: Build definition ID 830: Build ID 1396140
  • Filter to author association using GraphQL
  • Localized file check-in by OneLocBuild Task: Build definition ID 830: Build ID 1397059
  • Update dependencies from https://github.com/dotnet/arcade build 20210927.9
  • Update dependencies from https://github.com/dotnet/arcade build 20210927.11
  • update compiler version
  • silence new IDE analysis
  • update baselines
  • Update the flow analysis result evaluation to account the call site reachability (Update the flow analysis result evaluation to account the call site reachability dotnet/roslyn-analyzers#5571)
  • do not run code coverage in servicing repos
  • Fix query and filter logic for labeling community PRs
  • Add .NET 7 prerelease feed link to README
  • Update dependencies from https://github.com/dotnet/arcade build 20210929.4
  • Localized file check-in by OneLocBuild Task: Build definition ID 830: Build ID 1399764
  • Bringing in final loc strings
  • run /t:updatexlf
  • Avoid applying Community PR label to dotnet-bot and dotnet-maestro
  • Localized file check-in by OneLocBuild Task: Build definition ID 830: Build ID 1400584 (Localized file check-in by OneLocBuild Task: Build definition ID 830: Build ID 1400584 dotnet/roslyn-analyzers#5591)
  • Review automatic pull requests
  • run msbuild /t:pack
  • ensure globalconfig files are lowercase
  • Add title rule tests
  • Update dependencies from https://github.com/dotnet/arcade build 20211005.11
  • Update dependencies from https://github.com/dotnet/arcade build 20211005.8
  • Add message rule tests
  • Add description rule tests
  • Fix analyzer
  • Remove unused usings
  • Run msbuild
  • Handle an error case where GetOverriddenMembers() returns null for an indexer (PreviewFeatures - Handle an error case where GetOverriddenMembers() returns null for an indexer dotnet/roslyn-analyzers#5596)
  • Support Url and Message parameters in RequiresPreviewFeaturesAttribute (Support Url and Message parameters in RequiresPreviewFeaturesAttribute dotnet/roslyn-analyzers#5502)
  • [release/6.0.1xx] Update dependencies from dotnet/arcade ([release/6.0.1xx] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#5610)
  • add perf test
  • update perf baseline
  • skip analysis if no CancellationToken in parameters list
  • do not capture variables
  • use foreach
  • Update dependencies from https://github.com/dotnet/arcade build 20211008.2
  • [main] Update dependencies from dotnet/arcade ([main] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#5612)
  • Update dependencies from https://github.com/dotnet/arcade build 20211009.1
  • Exclude projects from source-build
  • Update newtonsoft.json version
  • Revert "Update newtonsoft.json version"
  • Update NetCore_GettingStarted.md
  • Update dependencies from https://github.com/dotnet/arcade build 20211011.3
  • use newever version of Microsoft.CodeAnalysis in tests
  • Update dependencies from https://github.com/dotnet/arcade build 20211012.4
  • [main] Update dependencies from dotnet/arcade ([main] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#5621)
  • Update dependencies from https://github.com/dotnet/arcade build 20211013.1 ([release/5.0.3xx] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#5629)
  • Update dependencies from https://github.com/dotnet/arcade build 20211013.3
  • Update dependencies from https://github.com/dotnet/arcade build 20211013.5
  • Update dependencies from https://github.com/dotnet/arcade build 20211013.6
  • Add end-to-end testing to the definition of done for .NET Analyzers (Add end-to-end testing to the definition of done for .NET Analyzers dotnet/roslyn-analyzers#5640)
  • Update dependencies from https://github.com/dotnet/arcade build 20211014.2
  • Split throw and yield parts of a function to avoid laziness issue
  • Add test
  • Remove unused generic types
  • Remove sub-classes
  • Update CA1010 to consider IReadOnlyXXX as valid counterpart
  • Remove unwanted change
  • Use StringBuilder instead of string concat in loops
  • Address review comments
  • Mark CA2252 as Error severity (Mark CA2252 as Error severity dotnet/roslyn-analyzers#5637)
  • Update dependencies from https://github.com/dotnet/arcade build 20211015.3
  • [main] Update dependencies from dotnet/arcade ([main] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#5643)
  • VB support for the virtual methods in DetectPreviewFeatureAnalyzer (VB support for the virtual methods in DetectPreviewFeatureAnalyzer dotnet/roslyn-analyzers#5566)
  • Switch to stable RTM branding ([release/6.0.1xx] Switch to stable RTM branding dotnet/roslyn-analyzers#5651)
  • [main] Update dependencies from dotnet/arcade ([main] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#5650)
  • Update dependencies from https://github.com/dotnet/arcade build 20211019.3
  • Do not mark .NET 7 packages as stable
  • Update dependencies from https://github.com/dotnet/arcade build 20211019.8
  • [Code Metrics] Upgrade MSBuild locator version
  • Bump version to 3.3.4
  • [New Analyzer/Fixer] Prefer static HashData method over ComputeHash ([New Analyzer/Fixer] Prefer static HashData method over ComputeHash dotnet/roslyn-analyzers#4797)
  • Update sairf files
  • Post release activities after release 3.3.3
  • A final newline to markdown files
  • [main] Update dependencies from dotnet/arcade ([main] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#5667)
  • fix warnings about using IsKind
  • Localized file check-in by OneLocBuild Task: Build definition ID 830: Build ID 1437904
  • Raise code fix for each applicable doc
  • convert to extension methods
  • [main] Update dependencies from dotnet/arcade ([main] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#5677)
  • Fix globalConfig generator tool
  • [main] Update dependencies from dotnet/arcade ([main] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#5680)
  • [main] Update dependencies from dotnet/arcade ([main] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#5686)
  • Update dependencies from https://github.com/dotnet/arcade build 20211102.1
  • Add using
  • Update CI build links
  • Update Versions.props
  • update sarif file
  • Fix CS2014 handling of stackalloc in a foreach expression (Fix CS2014 handling of stackalloc in a foreach expression dotnet/roslyn-analyzers#5700)
  • Localized file check-in by OneLocBuild Task: Build definition ID 830: Build ID 1454080
  • [main] Update dependencies from dotnet/arcade ([main] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#5701)
  • Fix CA2000 Dispose for MemoryStream dotnet/roslyn-analyzers#4147 - no more noisy pragmas needed for 'new System.IO.MemoryStream()'.
  • Declare MemoryStreamNamedType.get in the public API.
  • Fix CA1805 missing trivia (Fix CA1805 missing trivia dotnet/roslyn-analyzers#5531)
  • Fix CA1850 codefix not taking the original fully-qualified name into account (Fix CA1850 codefix not taking the original fully-qualified name into account dotnet/roslyn-analyzers#5687)
  • Fix CA1850 codefix to keep trivia if it's interesting (Fix CA1850 codefix to keep trivia if it's interesting dotnet/roslyn-analyzers#5703)
  • [main] Update dependencies from dotnet/arcade ([main] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#5708)
  • Replace rtf files by txt files
  • Update vsixmanifests
  • Update replaceme nuspec
  • Fix a bunch of RS1024 on Equals
  • Address review comments
  • Fix file header
  • Revert potentially problematic changes
  • Use an initializer for SupportedDiagnostics to guarantee one-time array allocation
  • Few more fixes
  • Fix extension
  • Use ArrayBuilder instead of ImmutableArray.Builder
  • Update src/Utilities/Compiler/Extensions/ISymbolExtensions.cs
  • Remove unused method
  • Remove un-needed pragma
  • [main] Update dependencies from dotnet/arcade ([main] Update dependencies from dotnet/arcade dotnet/roslyn-analyzers#5736)
  • Make DiagnosticDescriptors readonly
  • Remove unused project
  • Address review comments
  • CA1841: do not report on expression tree contexts
  • Revert whitespace changes
  • More whitespace revert
  • CA1827 CA1829 CA1836: Do not report within expression tree
  • Remove the full tools folder
  • Update src/Utilities/Compiler/SymbolEqualityComparer.cs
  • Add tests and fix broken case for CA1836
  • Update to .NET SDK 6.0.100
  • Fix incorrect targeting of net6.0 on unsupported platform
  • Allow GenerateAnalyzerNuspec to roll forward at execution time
  • Handle 'CodeAnalysisTreatWarningsAsErrors' correctly in props/targets
  • Avoid Path.GetFileName allocations in AdditionalFiles check
  • Localized file check-in by OneLocBuild Task: Build definition ID 830: Build ID 1545831
  • Support all Debug.Assert(...) overloads in flow analysis (Support all Debug.Assert(...) overloads in flow analysis dotnet/roslyn-analyzers#5764)
  • Localized file check-in by OneLocBuild Task: Build definition ID 830: Build ID 1552280
  • Update RulesMissingDocumentation.md
  • Add README.md
  • Fix markdown to lint errors
  • Add newline
  • Use WellKnownTypeNames
  • Test codefix
  • Don't split codefix and analyzer tests
  • Don't remove null suppression
  • Update DoNotUseEnumerableMethodsOnIndexableCollectionsInsteadUseTheCollectionDirectlyTests.cs
  • Fix PR template
  • Refactor tests
  • Fix CA1050 (declare types in namespaces) false positive with top-level statements
  • Rename AnalyzeSymbol to AnalyzeNamedType
  • Update UseNameofInPlaceOfString.cs
  • Update PULL_REQUEST_TEMPLATE.md
  • Don't throw exception: "Passing '.editorconfig' files as additional files is no longer needed."
  • Update PostReleaseActivities.md (Update PostReleaseActivities.md dotnet/roslyn-analyzers#5757)
  • Rename
  • Update README.md
  • Update README.md
  • Don't report compare symbols correctly for custom comparers
  • One more fix
  • Update src/Microsoft.CodeAnalysis.Analyzers/Core/MetaAnalyzers/CompareSymbolsCorrectlyAnalyzer.cs
  • Update CompareSymbolsCorrectlyAnalyzer.cs
  • Apply suggestions from code review
  • Address review comments
  • Fix crash and record diagnostic location in preview feature analyzer (Fix crash and record diagnostic location in preview feature analyzer dotnet/roslyn-analyzers#5809)
  • Apply suggestions from code review
  • use dotnet test instead of xunit.runner
  • use --blame on windows run

jmarolf and others added 30 commits October 3, 2021 18:17
@jmarolf
run /t:updatexlf
4176b82
Merge pull request dotnet#5590 from dotnet/merges/release/6.0.1xx-to-…
d740351 
…main

Merge release/6.0.1xx to main
Merge pull request dotnet#5588 from dotnet/merges/release/5.0.3xx-to-…
0d1a5de 
…release/6.0.1xx

Merge release/5.0.3xx to release/6.0.1xx
Merge pull request dotnet#5593 from dotnet/merges/release/6.0.1xx-to-…
b15cb0f 
…main

Merge release/6.0.1xx to main
@sharwell
Avoid applying Community PR label to dotnet-bot and dotnet-maestro
25c748e 
The API appears to occasionally return the wrong authorAssociation for
pull requests submitted by these users. Excluding them by name is the
easiest way to avoid applying the Community label to these pull
requests.
Localized file check-in by OneLocBuild Task: Build definition ID 830:…
0507d88 
… Build ID 1400584 (dotnet#5591)
@sharwell
Merge pull request dotnet#5595 from sharwell/community-pr
20c4998 
Avoid applying Community PR label to dotnet-bot and dotnet-maestro
@jmarolf
Merge pull request dotnet#5592 from jmarolf/port-latest-localization-…
49a5837 
…string

Update Loc strings for .NET Analyzers
@sharwell
Review automatic pull requests
ff3bd5b 
See dotnet#5563
See dotnet#5564
@jmarolf
run msbuild /t:pack
f754fd3
@jmarolf
ensure globalconfig files are lowercase
cd7a634
@sharwell
Merge pull request dotnet#5599 from sharwell/auto-review
f263e44 
Review automatic pull requests
@sharwell
Merge pull request dotnet#5598 from dotnet/merges/release/6.0.1xx-to-…
9f29b7c 
…main

Merge release/6.0.1xx to main
@NewellClark
Add title rule tests
78c8167
@jmarolf
Merge pull request dotnet#5601 from jmarolf/bugfix/emit-all-globalcon…
f368a7c 
…fig-files-as-lower-case
@jmarolf
Merge pull request dotnet#5600 from jmarolf/bugfix/emit-all-globalcon…
f1d626b 
…fig-files-as-lower-case
Merge pull request dotnet#5602 from dotnet/merges/release/6.0.1xx-to-…
675d11d 
…main

Merge release/6.0.1xx to main
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20211…
1d14766 
…005.11

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.21477.11 -> To Version 5.0.0-beta.21505.11
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20211…
c331c75 
…005.8

Microsoft.DotNet.Arcade.Sdk
 From Version 6.0.0-beta.21479.4 -> To Version 6.0.0-beta.21505.8
@NewellClark
Add message rule tests
b3c04a8
@NewellClark
Add description rule tests
46c7dcd
@NewellClark
Fix analyzer
b5c7887
@NewellClark
Remove unused usings
7121210
@NewellClark
Run msbuild
6adf814
@NewellClark
Merge branch 'main' into 5442-fix-DiagnosticDescriptorCreationAnalyze…
46e83a3 
…r-for-new-pattern
@jmarolf
Merge pull request dotnet#5603 from dotnet/darc-release/5.0.3xx-9a139…
405edb5 
…40c-790c-4c1e-8252-9c1b68c6854c
@jmarolf
Merge branch 'release/6.0.1xx' into merges/release/5.0.3xx-to-release…
fc07521 
…/6.0.1xx
@jmarolf
Merge pull request dotnet#5604 from dotnet/darc-release/6.0.1xx-5a611…
95e8e44 
…a06-bc51-46b4-b7fb-717f6ba5e47c
Merge pull request dotnet#5606 from dotnet/merges/release/5.0.3xx-to-…
cd0b4c3 
…release/6.0.1xx

Merge release/5.0.3xx to release/6.0.1xx
@jmarolf
Merge branch 'main' into merges/release/6.0.1xx-to-main
aa86fd2
Youssef1313 and others added 29 commits January 17, 2022 23:24
@Youssef1313
Refactor tests
ebc9fc3
@Youssef1313
Fix CA1050 (declare types in namespaces) false positive with top-leve…
f14cf77 
…l statements
@Youssef1313
Rename AnalyzeSymbol to AnalyzeNamedType
bbc1c39
@Youssef1313
Update UseNameofInPlaceOfString.cs
3ae8025
@Youssef1313
Update PULL_REQUEST_TEMPLATE.md
429c2ee
@mavasani
Merge pull request dotnet#5800 from Youssef1313/ca1050-top-level
6c43d21 
Fix CA1050 (declare types in namespaces) false positive with top-level statements
@Youssef1313
Don't throw exception: "Passing '.editorconfig' files as additional f…
3312d4d 
…iles is no longer needed."
@mavasani
Merge pull request dotnet#5803 from Youssef1313/patch-17
1818a53 
Don't throw exception: "Passing '.editorconfig' files as additional files is no longer needed."
@Youssef1313
Update PostReleaseActivities.md (dotnet#5757)
f471d33
@Youssef1313
Rename
c6b79d5
@Youssef1313
Update README.md
becced7
@Youssef1313
Update README.md
3df18d2
@Youssef1313
Don't report compare symbols correctly for custom comparers
1284917
@Youssef1313
One more fix
66fb852
@Youssef1313
Update src/Microsoft.CodeAnalysis.Analyzers/Core/MetaAnalyzers/Compar…
cdc44b2 
…eSymbolsCorrectlyAnalyzer.cs
@Youssef1313
Update CompareSymbolsCorrectlyAnalyzer.cs
19efd30
@Youssef1313 @Evangelink
Apply suggestions from code review
51fbca9 
Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
@Youssef1313
Address review comments
a70ef8e
@Youssef1313
Fix crash and record diagnostic location in preview feature analyzer (d…
824df07 
…otnet#5809)

* Fix crash and record diagnostic location in preview feature analyzer
@mavasani
Merge pull request dotnet#5798 from Youssef1313/patch-14
700bc93 
Fix PR template
@mavasani
Merge pull request dotnet#5796 from Youssef1313/ca1826-nullforgiving-fix
f1c0532 
CA1826 (Use property instead of Linq Enumerable method): Don't remove null suppression
@Youssef1313
Apply suggestions from code review
9f2324c
@mavasani
Merge pull request dotnet#5806 from Youssef1313/patch-11
50d35c8 
Update README.md
@mavasani
Merge pull request dotnet#5807 from Youssef1313/compare-symbols-corre…
3405da8 
…ctly-fp

Fix 'Compare symbols correctly' false positive with custom comparers
@mavasani
Merge pull request dotnet#5063 from Youssef1313/patch-16
07d99dc 
Refactor UseNameofInPlaceOfString
@jmarolf
use dotnet test instead of xunit.runner
5169862
@jmarolf
use --blame on windows run
95a8381
@jmarolf
add blame arguments to props file
5c68488
@jmarolf
publish test results
f3cd078
@jmarolf jmarolf closed this Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone