{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":126534401,"defaultBranch":"master","name":"kiali","ownerLogin":"jmazzitelli","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2018-03-23T20:12:54.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/2029470?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1723754125.0","currentOid":""},"activityList":{"items":[{"before":"f55e49623503663b1dae076e5a5a004514a59d1f","after":"7f6777fa13ce4b170008b25de4f62c2f5e0c645c","ref":"refs/heads/stop-kubecach-on-ns-delete","pushedAt":"2024-08-23T03:21:20.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"try to make sure refresh doesn't destroy and recreate the informers multiple times in quick succession","shortMessageHtmlLink":"try to make sure refresh doesn't destroy and recreate the informers m…"}},{"before":"fb3ca33e0d75043161533961d1a963390aa9adf8","after":"f55e49623503663b1dae076e5a5a004514a59d1f","ref":"refs/heads/stop-kubecach-on-ns-delete","pushedAt":"2024-08-23T02:59:58.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"try to make sure refresh doesn't destroy and recreate the informers multiple times in quick succession","shortMessageHtmlLink":"try to make sure refresh doesn't destroy and recreate the informers m…"}},{"before":"c3081e8c138d82fffd27fd74d51a31152cc8b05d","after":"fb3ca33e0d75043161533961d1a963390aa9adf8","ref":"refs/heads/stop-kubecach-on-ns-delete","pushedAt":"2024-08-23T02:56:38.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"try to make sure refresh doesn't destroy and recreate the informers multiple times in quick succession","shortMessageHtmlLink":"try to make sure refresh doesn't destroy and recreate the informers m…"}},{"before":"d2ec3ef894249134fd80e120f375bc10f445331b","after":"c3081e8c138d82fffd27fd74d51a31152cc8b05d","ref":"refs/heads/stop-kubecach-on-ns-delete","pushedAt":"2024-08-23T02:46:23.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"try to make sure refresh doesn't destroy and recreate the informers multiple times in quick succession","shortMessageHtmlLink":"try to make sure refresh doesn't destroy and recreate the informers m…"}},{"before":"0a1e11356bfc042b3373dd2e9d4cb9c21a9c15e2","after":"d2ec3ef894249134fd80e120f375bc10f445331b","ref":"refs/heads/stop-kubecach-on-ns-delete","pushedAt":"2024-08-23T02:30:49.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"try to make sure refresh doesn't destroy and recreate the informers multiple times in quick succession","shortMessageHtmlLink":"try to make sure refresh doesn't destroy and recreate the informers m…"}},{"before":"e23b53e2534ff3e83d8c4db24fddf9f0d560009d","after":"0a1e11356bfc042b3373dd2e9d4cb9c21a9c15e2","ref":"refs/heads/stop-kubecach-on-ns-delete","pushedAt":"2024-08-23T02:25:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"try to make sure refresh doesn't destroy and recreate the informers multiple times in quick succession","shortMessageHtmlLink":"try to make sure refresh doesn't destroy and recreate the informers m…"}},{"before":"bc6f38cf096ae8c5f99f5b13f6e69d122dbcff80","after":"e23b53e2534ff3e83d8c4db24fddf9f0d560009d","ref":"refs/heads/stop-kubecach-on-ns-delete","pushedAt":"2024-08-22T21:28:56.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"If a namespace appears to be deleted, stop the cache.\nThis stops flooding the logs with errors that come from the k8s client cache.\nThe kube_cache now calls back into kiali cache to clean up namespace stuff on namespace deletion.\nKiali cache then loops back and calls the kube_cache so it stops the namespace informers.\n\nThis also restart the cache if a namespace is re-created. If the cache lister doesn't exist,\nit is likely because the namespace was deleted and the informers were stopped;\nif we detect that, the namespace was probably re-created so this also refreshes the cache. It uses a lock\nto void deadlocks when getting listers concurrently.","shortMessageHtmlLink":"If a namespace appears to be deleted, stop the cache."}},{"before":"927840e0800431be8e3b11cb90be3ef755e31982","after":"a8af71ec8917473a9ff2580374af7a1d80b8df33","ref":"refs/heads/discovery-selectors","pushedAt":"2024-08-19T19:53:01.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"do NOT use Istio discovery selectors","shortMessageHtmlLink":"do NOT use Istio discovery selectors"}},{"before":"030e10adcc22a001382eef478b2232a76df19604","after":"bc6f38cf096ae8c5f99f5b13f6e69d122dbcff80","ref":"refs/heads/stop-kubecach-on-ns-delete","pushedAt":"2024-08-15T20:51:40.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"if a namespace appears to be deleted, stop the cache\nThis stops flooding the logs with errors that come from the k8s client cache","shortMessageHtmlLink":"if a namespace appears to be deleted, stop the cache"}},{"before":null,"after":"030e10adcc22a001382eef478b2232a76df19604","ref":"refs/heads/stop-kubecach-on-ns-delete","pushedAt":"2024-08-15T20:35:25.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"if a namespace appears to be deleted, stop the cache\nThis stops flooding the logs with errors that come from the k8s client cache","shortMessageHtmlLink":"if a namespace appears to be deleted, stop the cache"}},{"before":"17178649bb16d9bc9990e0f620de4b2ff2354e6d","after":"927840e0800431be8e3b11cb90be3ef755e31982","ref":"refs/heads/discovery-selectors","pushedAt":"2024-08-15T15:33:13.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"do NOT use Istio discovery selectors","shortMessageHtmlLink":"do NOT use Istio discovery selectors"}},{"before":"021cbf2cde3abbdb5035867c73dd4ad426451312","after":"17178649bb16d9bc9990e0f620de4b2ff2354e6d","ref":"refs/heads/discovery-selectors","pushedAt":"2024-08-07T20:09:17.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"do NOT use Istio discovery selectors","shortMessageHtmlLink":"do NOT use Istio discovery selectors"}},{"before":"5205a5c32d5e5ba450e048016c3dd8191683f14c","after":"021cbf2cde3abbdb5035867c73dd4ad426451312","ref":"refs/heads/discovery-selectors","pushedAt":"2024-08-07T17:12:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"do NOT use Istio discovery selectors","shortMessageHtmlLink":"do NOT use Istio discovery selectors"}},{"before":"514e05ea70d8a0e2c913ae4d66a33bd4e0b02b4c","after":"5205a5c32d5e5ba450e048016c3dd8191683f14c","ref":"refs/heads/discovery-selectors","pushedAt":"2024-08-07T05:19:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"move the check for accessibility up above to fail-faster. no sense going through the client and doing the rest of that work if we can easily determine if the namespace isn't accessible. The isAccessibleNamespace function should be fast.","shortMessageHtmlLink":"move the check for accessibility up above to fail-faster. no sense go…"}},{"before":"fea15d389b28de33381b8fc6ae3bb3d0ad51276d","after":"514e05ea70d8a0e2c913ae4d66a33bd4e0b02b4c","ref":"refs/heads/discovery-selectors","pushedAt":"2024-08-07T05:14:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"move the check for accessibility up above to fail-faster. no sense going through the client and doing the rest of that work if we can easily determine if the namespace isn't accessible. The isAccessibleNamespace function should be fast.","shortMessageHtmlLink":"move the check for accessibility up above to fail-faster. no sense go…"}},{"before":"6f9e3637dfb1b7510457f79f8cca2718ffebd425","after":"fea15d389b28de33381b8fc6ae3bb3d0ad51276d","ref":"refs/heads/discovery-selectors","pushedAt":"2024-08-07T03:01:11.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"add a test func to prepare the config in a way that exercised the actual unmarshal code which also exercises the discovery selector-to-accessible-namespace conversion","shortMessageHtmlLink":"add a test func to prepare the config in a way that exercised the act…"}},{"before":"337667d018936677bee3164fc41db9e860f894ee","after":"6f9e3637dfb1b7510457f79f8cca2718ffebd425","ref":"refs/heads/discovery-selectors","pushedAt":"2024-08-07T01:53:30.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"add a test func to prepare the config in a way that exercised the actual unmarshal code which also exercises the discovery selector-to-accessible-namespace conversion","shortMessageHtmlLink":"add a test func to prepare the config in a way that exercised the act…"}},{"before":"74d121d120e48bdf5090a4183109c5449758461a","after":"337667d018936677bee3164fc41db9e860f894ee","ref":"refs/heads/discovery-selectors","pushedAt":"2024-08-07T01:50:09.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"add a test func to prepare the config in a way that exercised the actual unmarshal code which also exercises the discovery selector-to-accessible-namespace conversion","shortMessageHtmlLink":"add a test func to prepare the config in a way that exercised the act…"}},{"before":"54be65e4afc3319651400d77d285d3e52ed98f9e","after":"74d121d120e48bdf5090a4183109c5449758461a","ref":"refs/heads/discovery-selectors","pushedAt":"2024-08-07T01:47:21.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"add a test func to prepare the config in a way that exercised the actual unmarshal code which also exercises the discovery selector-to-accessible-namespace conversion","shortMessageHtmlLink":"add a test func to prepare the config in a way that exercised the act…"}},{"before":"5e1264561842a8287489e3ca1a31141391e9da43","after":"54be65e4afc3319651400d77d285d3e52ed98f9e","ref":"refs/heads/discovery-selectors","pushedAt":"2024-08-07T01:45:23.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"add a test func to prepare the config in a way that exercised the actual unmarshal code which also exercises the discovery selector-to-accessible-namespace conversion","shortMessageHtmlLink":"add a test func to prepare the config in a way that exercised the act…"}},{"before":"35df0c382a9b37127a83421a7e1857a564d1a20b","after":"5e1264561842a8287489e3ca1a31141391e9da43","ref":"refs/heads/discovery-selectors","pushedAt":"2024-08-07T01:43:13.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"add a test func to prepare the config in a way that exercised the actual unmarshal code which also exercises the discovery selector-to-accessible-namespace conversion","shortMessageHtmlLink":"add a test func to prepare the config in a way that exercised the act…"}},{"before":"50c67b7510bb814a97d701ac2c588c62b286e3f6","after":"35df0c382a9b37127a83421a7e1857a564d1a20b","ref":"refs/heads/discovery-selectors","pushedAt":"2024-08-07T01:32:57.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"add a test func to prepare the config in a way that exercised the actual unmarshal code which also exercises the discovery selector-to-accessible-namespace conversion","shortMessageHtmlLink":"add a test func to prepare the config in a way that exercised the act…"}},{"before":"11e15132e42dad7cce50ac1c90b9a2fbc495bab6","after":"50c67b7510bb814a97d701ac2c588c62b286e3f6","ref":"refs/heads/discovery-selectors","pushedAt":"2024-08-07T01:28:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"add a test func to prepare the config in a way that exercised the actual unmarshal code which also exercises the discovery selector-to-accessible-namespace conversion","shortMessageHtmlLink":"add a test func to prepare the config in a way that exercised the act…"}},{"before":"b5b367167329f0b7fa83f2a70384eb09d71bca39","after":"11e15132e42dad7cce50ac1c90b9a2fbc495bab6","ref":"refs/heads/discovery-selectors","pushedAt":"2024-08-07T00:08:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"cache the accessible namespaces within the config object","shortMessageHtmlLink":"cache the accessible namespaces within the config object"}},{"before":"43f26af51774c41264e555d4897c0c4b9b9e1a8e","after":"b5b367167329f0b7fa83f2a70384eb09d71bca39","ref":"refs/heads/discovery-selectors","pushedAt":"2024-08-06T19:22:24.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"move filtering to the end; no need to explicitly code it in every if-else clause.","shortMessageHtmlLink":"move filtering to the end; no need to explicitly code it in every if-…"}},{"before":"8fe45a153fda1ab8c138da2d51bf12f05203b687","after":"43f26af51774c41264e555d4897c0c4b9b9e1a8e","ref":"refs/heads/discovery-selectors","pushedAt":"2024-08-03T06:40:04.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"accessible namespaces / discovery selectors refactoring","shortMessageHtmlLink":"accessible namespaces / discovery selectors refactoring"}},{"before":"864eb6ed6f90bd863feddfe1185d66557c8e13de","after":"8fe45a153fda1ab8c138da2d51bf12f05203b687","ref":"refs/heads/discovery-selectors","pushedAt":"2024-08-02T22:36:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"change run kiali template to remove accessible namespaces","shortMessageHtmlLink":"change run kiali template to remove accessible namespaces"}},{"before":"cee1e45bf7e155f934b8a593d4ab4b3e82635581","after":"864eb6ed6f90bd863feddfe1185d66557c8e13de","ref":"refs/heads/discovery-selectors","pushedAt":"2024-08-02T18:54:34.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"accessible namespaces / discovery selectors refactoring","shortMessageHtmlLink":"accessible namespaces / discovery selectors refactoring"}},{"before":"be3fa7d34245e50d2f4704c6810185093bded580","after":"cee1e45bf7e155f934b8a593d4ab4b3e82635581","ref":"refs/heads/discovery-selectors","pushedAt":"2024-08-02T15:22:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"move extraction code to config","shortMessageHtmlLink":"move extraction code to config"}},{"before":"e8f749f1e88942c589cab9a35fcb31ea68067d46","after":"be3fa7d34245e50d2f4704c6810185093bded580","ref":"refs/heads/discovery-selectors","pushedAt":"2024-08-02T13:46:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"jmazzitelli","name":"John Mazzitelli","path":"/jmazzitelli","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2029470?s=80&v=4"},"commit":{"message":"explicitly set CWA to true in the remote secret script to make it clear we\nwant to install the cluster role (this is default already, but we want\nto be explicit here so we are clear we want this).","shortMessageHtmlLink":"explicitly set CWA to true in the remote secret script to make it cle…"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEoe06_gA","startCursor":null,"endCursor":null}},"title":"Activity · jmazzitelli/kiali"}