Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabulatedModel x fitting data that works for single property or property group #105

Open
ConnorPigg opened this issue Jul 16, 2019 · 1 comment

Comments

@ConnorPigg
Copy link
Collaborator

The tabulated model should be able to accept x values to be used to fit either a single property or a composite model for multiple properties. The problem is that there is not enough information to distinguish if the x is a feature_domain of a set of properties or simply a set of x. If it is a feature_domain, how to identify the slice to use as the x for interpolation? This problem does not occur for the LinearModel as the model is independent of x. Further, LinearModel requires prop.x to be a subset of x which covers both the case of a single property or a property group. Need a stronger definition of the interface of tabulated model.

@jmborr
Copy link
Owner

jmborr commented Jul 17, 2019

Good issue. How about a TabulatedCompositeModel ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants