Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anyone experienced rh.get_all_open_option_orders(account_number=acct) is very slow? e.g. ~2 minutes #507

Open
mw66 opened this issue Nov 26, 2024 · 5 comments · May be fixed by #525
Open

Comments

@mw66
Copy link

mw66 commented Nov 26, 2024

Hi,

Just wonder if anyone experienced rh.get_all_open_option_orders(account_number=acct) is very slow? e.g. ~2 minutes

Is this a server problem, or anything we can improve it on the client side code?

Thanks.

@noLeash
Copy link
Contributor

noLeash commented Dec 10, 2024

@mw66 Yes, I was having this issue and have resolved it. The problem is that it's requesting the entire list of transactions for the account. I've started a fork that solves this issue by letting you send a start datetime for how far back to request records, and I will post the update tomorrow.

@noLeash
Copy link
Contributor

noLeash commented Dec 10, 2024

@mw66
Copy link
Author

mw66 commented Dec 10, 2024

@noLeash Thanks for the information and the fork, can you make a PR and contribute back to the original repo?

@jmfernandes

@noLeash
Copy link
Contributor

noLeash commented Dec 11, 2024

@mw66 - PR has been submitted #517

@OnishiKenshin
Copy link

@noLeash hey, just wanted to comment a thanks for your fix on this.

@mw66 mw66 linked a pull request Dec 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants