Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji that you can chain together in Slack #4

Merged

Conversation

ianfixes
Copy link
Contributor

@ianfixes ianfixes commented Mar 1, 2016

This pull request speaks for itself.

Before

shuffle1shuffle2shuffle1shuffle2shuffle1shuffle2shuffle1shuffle2shuffle1shuffle2shuffle1shuffle2shuffle1shuffle2shuffle1

After

shuffle1shuffle2shuffle1shuffle2shuffle1shuffle2shuffle1shuffle2shuffle1shuffle2shuffle1shuffle2shuffle1shuffle2shuffle1shuffle2shuffle1shuffle2

@jmhobbs
Copy link
Owner

jmhobbs commented Mar 1, 2016

shuffleparrot and shufflefurtherparrot used to work that way. Instead of shuffleparrot2, want to just override shufflefurtherparrot?

I've always thought shufflefurtherparrot was too fast anyway.

@ianfixes
Copy link
Contributor Author

ianfixes commented Mar 1, 2016

That was actually my first thought, but then I noticed that shufflefurtherparrot does indeed shuffle a few pixels faster in the middle.

@ianfixes ianfixes force-pushed the 2016-03-01_every_day_its_shuffling branch from a92916e to 3c6c38a Compare March 1, 2016 20:10
@jmhobbs
Copy link
Owner

jmhobbs commented Mar 1, 2016

Yeah, that's just my lack of gif editing ability. I'm all for replacing that one. It's pretty much only used when chained with the first one.

@ianfixes
Copy link
Contributor Author

ianfixes commented Mar 1, 2016

Note that I've fixed it as per your comments -- I squashed the old commit by push -f

jmhobbs added a commit that referenced this pull request Mar 1, 2016
@jmhobbs jmhobbs merged commit 5733430 into jmhobbs:master Mar 1, 2016
@jmhobbs
Copy link
Owner

jmhobbs commented Mar 1, 2016

Hah! Tricky tricky :)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants