forked from argoproj/argo-cd
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: expose notification secrets for request payload templating (arg…
…oproj#16055) Signed-off-by: Etien Roznik <12816736+eroznik@users.noreply.github.com> Signed-off-by: jmilic1 <70441727+jmilic1@users.noreply.github.com>
- Loading branch information
Showing
3 changed files
with
127 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,92 @@ | ||
package settings | ||
|
||
import ( | ||
"fmt" | ||
"testing" | ||
|
||
"github.com/argoproj/argo-cd/v2/reposerver/apiclient/mocks" | ||
service "github.com/argoproj/argo-cd/v2/util/notification/argocd" | ||
"github.com/argoproj/notifications-engine/pkg/api" | ||
"github.com/argoproj/notifications-engine/pkg/services" | ||
"github.com/stretchr/testify/assert" | ||
"github.com/stretchr/testify/require" | ||
corev1 "k8s.io/api/core/v1" | ||
v1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
"k8s.io/client-go/kubernetes/fake" | ||
) | ||
|
||
const testNamespace = "default" | ||
const testContextKey = "test-context-key" | ||
const testContextKeyValue = "test-context-key-value" | ||
|
||
func TestInitGetVars(t *testing.T) { | ||
notificationsCm := corev1.ConfigMap{ | ||
ObjectMeta: v1.ObjectMeta{ | ||
Namespace: testNamespace, | ||
Name: "argocd-notifications-cm", | ||
}, | ||
Data: map[string]string{ | ||
"context": fmt.Sprintf("%s: %s", testContextKey, testContextKeyValue), | ||
"service.webhook.test": "url: https://test.com", | ||
"template.app-created": "email:\n subject: Application {{.app.metadata.name}} has been created.\nmessage: Application {{.app.metadata.name}} has been created.\nteams:\n title: Application {{.app.metadata.name}} has been created.\n", | ||
"trigger.on-created": "- description: Application is created.\n oncePer: app.metadata.name\n send:\n - app-created\n when: \"true\"\n", | ||
}, | ||
} | ||
notificationsSecret := corev1.Secret{ | ||
ObjectMeta: v1.ObjectMeta{ | ||
Name: "argocd-notifications-secret", | ||
Namespace: testNamespace, | ||
}, | ||
Data: map[string][]byte{ | ||
"notification-secret": []byte("secret-value"), | ||
}, | ||
} | ||
kubeclientset := fake.NewSimpleClientset(&corev1.ConfigMap{ | ||
ObjectMeta: v1.ObjectMeta{ | ||
Namespace: testNamespace, | ||
Name: "argocd-notifications-cm", | ||
}, | ||
Data: notificationsCm.Data, | ||
}, | ||
&corev1.Secret{ | ||
ObjectMeta: v1.ObjectMeta{ | ||
Name: "argocd-notifications-secret", | ||
Namespace: testNamespace, | ||
}, | ||
Data: notificationsSecret.Data, | ||
}) | ||
mockRepoClient := &mocks.Clientset{RepoServerServiceClient: &mocks.RepoServerServiceClient{}} | ||
argocdService, err := service.NewArgoCDService(kubeclientset, testNamespace, mockRepoClient) | ||
require.NoError(t, err) | ||
defer argocdService.Close() | ||
config := api.Config{} | ||
testDestination := services.Destination{ | ||
Service: "webhook", | ||
} | ||
emptyAppData := map[string]interface{}{} | ||
|
||
varsProvider, _ := initGetVars(argocdService, &config, ¬ificationsCm, ¬ificationsSecret) | ||
|
||
t.Run("Vars provider serves Application data on app key", func(t *testing.T) { | ||
appData := map[string]interface{}{ | ||
"name": "app-name", | ||
} | ||
result := varsProvider(appData, testDestination) | ||
assert.NotNil(t, t, result["app"]) | ||
assert.Equal(t, result["app"], appData) | ||
}) | ||
t.Run("Vars provider serves notification context data on context key", func(t *testing.T) { | ||
expectedContext := map[string]string{ | ||
testContextKey: testContextKeyValue, | ||
"notificationType": testDestination.Service, | ||
} | ||
result := varsProvider(emptyAppData, testDestination) | ||
assert.NotNil(t, result["context"]) | ||
assert.Equal(t, result["context"], expectedContext) | ||
}) | ||
t.Run("Vars provider serves notification secrets on secrets key", func(t *testing.T) { | ||
result := varsProvider(emptyAppData, testDestination) | ||
assert.NotNil(t, result["secrets"]) | ||
assert.Equal(t, result["secrets"], notificationsSecret.Data) | ||
}) | ||
} |