Make SymbolMorphs match height of input in blocks. #2952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you elaborate a little bit what this PR addresses, perhaps with a screenshot before and after? seems like the only change is an adjustment factor.... |
|
Yes it's a very minor tweak. It standardizes the height of blocks. Please disregard the silly grey block name in the gif it's unimportant.
As you can see in the animation this pull tweaks things so that the blocks with SymbolMorphs and the blocks with inputs are of the same height. I'm still trying to decide how to best standardize the size of blocks containing only BlockLabelMorphs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes blocks containing BlockSymbolMorph parts match the height of blocks with input(s) .
TODO increase height of blocks containing only BlockLabelMorphs to match.