Prepared statements broken when using "Named" + "In"

[samber]

Hi @jmoiron and thanks for your work on this lib!

On the following example: http://jmoiron.github.io/sqlx/#namedParams, you show how to combine Named params and IN, in a single statement.

This is broken since -at least- sqlx@1.3.0 and on master branch.

Example with the following table:

CREATE TABLE (foo text, bar text);

The following code:

type Test struct {
  Foo string `db:"foo"`
  Bar string `db:"bar"`
}

test := []Test{
  {Foo: "hello", Bar: "world 1"},
  {Foo: "hello", Bar: "world 2"},
}

query := "INSERT INTO test (foo, bar) VALUES (:foo, :bar);"
query, args, err := sqlx.Named(, arg)
query, args, err := sqlx.In(query, args...)
query = db.Rebind(query)
_, err := db.Query(query, args...)

fmt.Println(err.Error())
// "pq: got 4 parameters but the statement requires 2"

fmt.Println(query)
// "INSERT INTO test (foo, bar) VALUES (?, ?);"
fmt.Println(args)
// [hello world 1 hello world 2]

Any idea?

[kgritesh]

Facing the same issue?

[pete-woods]

Another person suffering the same issue here

[gnuletik]

v1.3.3 seems to fix the issue :)

[jmoiron]

If it wasn't fixed in v1.3.3, there's another fix for these types of issues in v1.3.4

[0x457]

batch insert for support oracle? I got the same error