Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Downloading from custom repo always downloads electron.zip #67

Open
joaomoreno opened this issue Jan 25, 2021 · 1 comment
Open

Downloading from custom repo always downloads electron.zip #67

joaomoreno opened this issue Jan 25, 2021 · 1 comment
Assignees

Comments

@joaomoreno
Copy link
Owner

The adoption to download ffmpeg and other components was never adopted in:

async function getDownloadUrl(repoUrl, { version, platform, arch, token }) {

cc @deepak1556, related to #59

@joaomoreno
Copy link
Owner Author

I seriously can't believe how hard it is to get the latest gulp-atom-electron to work on VS Code.

I have adopted the mirror option: d4e0687

But now authentication doesn't seem to work at all, and that's a problem given our private electron repo. Even after setting everything correctly: 9bc9b52

To be continued...

@joaomoreno joaomoreno self-assigned this Jan 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant