-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support multi-module java projects #546
Conversation
will work on test errors after I figure out how to run travis locally |
I haven't had time to look at your pull request, but I can comment on this matter. Travis CI is broken for Eglot for a number of weeks now, but |
It seems that everything is working properly with eclipse.jdt.ls. I had problems with pyls, but once I disabled it, tests pass:
|
Could you link an example of a project where I could test your patch? It could be a real project you are working on or whatever, basically just some repository I could clone. Thanks. |
I was using my work code to test this, so no I can't. I've already switched to the other implementation. Just make any 3-level deep maven project or just delete this PR. |
I'd rather not delete the PR if it is useful. :-) Please help me here, as I have forgotten all Java I once know (or so it feels). What is a "3-level deep maven project"? Does that refer to the directory structure? Does simple-java-maven-app fit the bill? Thanks. |
ok, I'll prepare something. please give me some time. |
BTW, it would be even better if we could have a test case for this, of course. |
Sorry I've never written unit tests for emacs. Here is a sample project https://github.com/ukaszg/java-test The issue was, that the current implementation would find nested project "two" but wouldn't dig deep enough to find "three". |
Thanks, that helps! I'll look into it. |
I say this methaphoricaly, but this commit is a monster. @ukaszg how about coming up with a non-ELisp shell script that does these things and starts whatever |
Fixes #541
This will support recursive maven,etc. projects of any depth and with or without git subrepositories.