Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Id in live url is sometimes different from the windmill id #22

Closed
6 tasks done
blieven1 opened this issue Jun 9, 2022 · 5 comments · Fixed by #23 or #25
Closed
6 tasks done

Id in live url is sometimes different from the windmill id #22

blieven1 opened this issue Jun 9, 2022 · 5 comments · Fixed by #23 or #25
Assignees
Labels
bug Something isn't working

Comments

@blieven1
Copy link

blieven1 commented Jun 9, 2022

Checklist

  • I'm running the latest version of the Windcentrale integration.
  • I checked if there is not a duplicate issue with the same question.
  • I have read the README.md page.
  • This issue is a bug related to the Windcentrale integration.
  • This issue only contains 1 issue (if you have multiple issues, open one issue for each issue).
  • I have filled out the issue template to the best of my ability.

The problem

I noticed I didn't get complete data for the Boerenzwaluw.

Apperently the id is 191 so the main url is : https://zep-api.windcentrale.nl/production/191
but the live url is https://zep-api.windcentrale.nl/production/201/live for some reason

https://zep-api.windcentrale.nl/production/201 looks like it gives the same data as https://zep-api.windcentrale.nl/production/191
so maybe it's just an update from 191 tot 201 as the id.

complete list: https://github.com/damonnk/windcentrale/blob/master/molens.xml

What is version of Home Assistant Core did you recieve the bug?

2022.6.4

What is version of Home Assistant Supervisor did you recieve the bug?

None

What is version of Home Assistant Supervisor?

2022.6.4

What is version of the Windcentrale integration?

1.4

Example Code snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

@blieven1 blieven1 added the bug Something isn't working label Jun 9, 2022
@blieven1
Copy link
Author

blieven1 commented Jun 9, 2022

Verified with the data on https://mijnmolen.windcentrale.nl/#/

Boerenzwaluw should have 201 as the id

@jobvk jobvk self-assigned this Jun 9, 2022
@jobvk jobvk mentioned this issue Jun 9, 2022
@jobvk jobvk linked a pull request Jun 9, 2022 that will close this issue
@jobvk
Copy link
Owner

jobvk commented Jun 9, 2022

I made a beta release, please check if in this beta the problem still occurs.

You update to this beta through HACS

@blieven1
Copy link
Author

Hi, It is working.

I also tried yesterday evening by just changing the id from 191 tot 201 in

"De Boerenzwaluw": [191, "Enercon", "E-44", "Burum", 53.265376, 6.214152, dt.datetime(2016, 8, 1)],

"De Boerenzwaluw": [201, "Enercon", "E-44", "Burum", 53.265376, 6.214152, dt.datetime(2016, 8, 1)],

Maybe that's a cleaner solution than having the if statement :)

Kind regards,
Bjorn

@jobvk
Copy link
Owner

jobvk commented Jun 10, 2022

Yes, it would be nicer.
But the problem is there are two API's working for production data:

And the problem is the data is a little bit different.

Also the news api uses the id of 191
image
So if i change the id of the windturbine to 201 the news filter doesn't work anymore

@blieven1
Copy link
Author

blieven1 commented Jun 10, 2022

Ok, thanx, didn't know about the news feed.

Great work!

jobvk pushed a commit that referenced this issue Jun 28, 2022
@jobvk jobvk linked a pull request Jun 28, 2022 that will close this issue
@jobvk jobvk closed this as completed in #25 Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants