Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails 4.2 #46

Merged
merged 1 commit into from
Jan 2, 2015
Merged

Rails 4.2 #46

merged 1 commit into from
Jan 2, 2015

Conversation

ajb
Copy link
Contributor

@ajb ajb commented Dec 25, 2014

Removing the use of Responders since they've been extracted out of core Rails.

@joecorcoran
Copy link
Collaborator

Tests failed – still requiring responders in lib/judge/controller.rb and the gem would need to be removed from the Appraisals file as well. Can you fix so I can merge?

@ajb
Copy link
Contributor Author

ajb commented Jan 2, 2015

Thanks, and sorry, this PR was made in the middle of a headache-y upgrade to 4.2 :P.

Just fixed and rebased, let's see if the tests pass now...

joecorcoran added a commit that referenced this pull request Jan 2, 2015
@joecorcoran
Merge pull request #46 from ajb/rails-4.2
95950d7 
Rails 4.2
@joecorcoran joecorcoran merged commit 95950d7 into judgegem:master Jan 2, 2015
@joecorcoran
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajb @joecorcoran