Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

test-only packages are not run on save #732

Closed
zmb3 opened this issue Jan 9, 2018 · 0 comments
Closed

test-only packages are not run on save #732

zmb3 opened this issue Jan 9, 2018 · 0 comments

Comments

@zmb3
Copy link
Collaborator

zmb3 commented Jan 9, 2018

If a package contains only tests (ie all files end in _test.go), go-plus does not correctly run tests on save. While this isn't super common, you occasionally run into packages like this for integration tests.

The reason this doesn't work is because our save event handler runs go build prior to go test, and doesn't run tests if go build fails. It looks like go build returns a non-zero exit code in this case, which looks just like a compiler error.

We could detect this case by looking at go build's stderr and searching for no non-test Go files in.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant