Skip to content
This repository has been archived by the owner on May 7, 2021. It is now read-only.

Tests fail on Go develoment builds. #93

Closed
hansrodtang opened this issue Nov 16, 2014 · 6 comments
Closed

Tests fail on Go develoment builds. #93

hansrodtang opened this issue Nov 16, 2014 · 6 comments
Milestone

Comments

@hansrodtang
Copy link
Contributor

Probably not the most serious of issues, but I thought I should comment on it.

The parsing in goexecutable.coffee fetches the name from the version string, which in development builds does not contain the word "go", making the tests fail.

The test failing is this one here: goexecutable-spec.coffee

Getting go name from components[0] could solve line 38, not sure how to handle version testing, or if it is even needed.

@joefitzgerald
Copy link
Owner

Yeah, it's probably not even critical to have those assertions. What is the value for name in a development build?

@hansrodtang
Copy link
Contributor Author

The entire output of go version:

go version devel +723ca3789b88 Sat Nov 15 13:27:05 2014 +1100 darwin/amd64

@joefitzgerald joefitzgerald modified the milestone: Unscheduled Nov 17, 2014
@joefitzgerald
Copy link
Owner

Release candidates and betas seem to have information in go version that would make the tests pass. Are you referring to scenarios where you build go from source?

@hansrodtang
Copy link
Contributor Author

Yes, development builds which are just snapshots of the current development. Betas/RCs have prepared versioning.

So yeah, probably a mildly obscure issue, but if all other tests complete just fine, the version number shouldn't really matter.

@joefitzgerald
Copy link
Owner

@hansrodtang Can you test with the latest in master and let me know if this does the trick?

@hansrodtang
Copy link
Contributor Author

After removing the code.google.com import path for the cover tool (Go 1.4 does not accept it) it builds just fine (Build log)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants