Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deserialize method should not return unit #87

Open
knocte opened this issue Apr 21, 2020 · 1 comment · May be fixed by #236
Open

Deserialize method should not return unit #87

knocte opened this issue Apr 21, 2020 · 1 comment · May be fixed by #236

Comments

@knocte
Copy link
Collaborator

knocte commented Apr 21, 2020

The consequence of this is that the types need their members to be mutable, which is ugly.
@knocte knocte mentioned this issue Apr 21, 2020
Merged
@joemphilips
Copy link
Owner

Yes, I totally agree. But right now I suppose the priority to refactor it is low.

If there are any particular example that it is doing harm, I like to know about it.

@webwarrior-ws webwarrior-ws linked a pull request Oct 13, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

No mutable fields in message records webwarrior-ws/DotNetLightning
2 participants
@knocte @joemphilips