From ba5c77155a6b0263f48f24f93033c7a386bc83b6 Mon Sep 17 00:00:00 2001 From: modernletter <50334733+modernletter@users.noreply.github.com> Date: Thu, 30 Nov 2023 07:51:37 +0100 Subject: [PATCH] fix: Add missing includes (#1306) CC version 13 needs `` to be explicitly included to provide fixed bits integer types. Some files using it inludes ``, some are missing direct or undirect inclusion. This PR adds `` inclusion to the minimal set of files, allowing compilation on GCC 13. Closes #1305 --- AUTHORS | 1 + CONTRIBUTORS | 1 + packager/hls/base/tag.h | 1 + packager/hls/public/hls_params.h | 1 + packager/media/base/buffer_writer.h | 1 + packager/media/base/fourccs.h | 1 + packager/media/base/id3_tag.h | 1 + packager/media/base/id3_tag_unittest.cc | 2 ++ packager/packager.h | 1 + 9 files changed, 10 insertions(+) diff --git a/AUTHORS b/AUTHORS index 99c8ec452c9..cca75e02ec2 100644 --- a/AUTHORS +++ b/AUTHORS @@ -18,6 +18,7 @@ Alen Vrecko Amazon Music <*@amazon.com> Anders Hasselqvist Audible <*@audible.com> +Cyfrowy Polsat SA <*@cyfrowypolsat.pl> Chun-da Chen Daniel CantarĂ­n Dolby Laboratories <*@dolby.com> diff --git a/CONTRIBUTORS b/CONTRIBUTORS index eeeeaa47fb4..084f46a8a85 100644 --- a/CONTRIBUTORS +++ b/CONTRIBUTORS @@ -40,6 +40,7 @@ Kongqun Yang Leandro Moreira Leo Law Marcus Spangenberg +Michal Wierzbicki Ole Andre Birkedal Piotr Srebrny Qingquan Wang diff --git a/packager/hls/base/tag.h b/packager/hls/base/tag.h index 481fdc8126f..e69f1fc56ff 100644 --- a/packager/hls/base/tag.h +++ b/packager/hls/base/tag.h @@ -7,6 +7,7 @@ #ifndef PACKAGER_HLS_BASE_TAG_H_ #define PACKAGER_HLS_BASE_TAG_H_ +#include #include namespace shaka { diff --git a/packager/hls/public/hls_params.h b/packager/hls/public/hls_params.h index d1f7200f439..0f61a077c83 100644 --- a/packager/hls/public/hls_params.h +++ b/packager/hls/public/hls_params.h @@ -7,6 +7,7 @@ #ifndef PACKAGER_HLS_PUBLIC_HLS_PARAMS_H_ #define PACKAGER_HLS_PUBLIC_HLS_PARAMS_H_ +#include #include namespace shaka { diff --git a/packager/media/base/buffer_writer.h b/packager/media/base/buffer_writer.h index 6abc978dfe9..5ea66cc7e2b 100644 --- a/packager/media/base/buffer_writer.h +++ b/packager/media/base/buffer_writer.h @@ -7,6 +7,7 @@ #ifndef PACKAGER_MEDIA_BASE_BUFFER_WRITER_H_ #define PACKAGER_MEDIA_BASE_BUFFER_WRITER_H_ +#include #include #include "packager/base/macros.h" diff --git a/packager/media/base/fourccs.h b/packager/media/base/fourccs.h index c721f2c81f5..d7a73fe47e7 100644 --- a/packager/media/base/fourccs.h +++ b/packager/media/base/fourccs.h @@ -5,6 +5,7 @@ #ifndef PACKAGER_MEDIA_BASE_FOURCCS_H_ #define PACKAGER_MEDIA_BASE_FOURCCS_H_ +#include #include namespace shaka { diff --git a/packager/media/base/id3_tag.h b/packager/media/base/id3_tag.h index 963814aee7b..9bd94a78f53 100644 --- a/packager/media/base/id3_tag.h +++ b/packager/media/base/id3_tag.h @@ -7,6 +7,7 @@ #ifndef PACKAGER_MEDIA_BASE_ID3_TAG_H_ #define PACKAGER_MEDIA_BASE_ID3_TAG_H_ +#include #include #include diff --git a/packager/media/base/id3_tag_unittest.cc b/packager/media/base/id3_tag_unittest.cc index fdbcdf31000..f70ddb73fce 100644 --- a/packager/media/base/id3_tag_unittest.cc +++ b/packager/media/base/id3_tag_unittest.cc @@ -4,6 +4,8 @@ // license that can be found in the LICENSE file or at // https://developers.google.com/open-source/licenses/bsd +#include + #include "packager/media/base/id3_tag.h" #include diff --git a/packager/packager.h b/packager/packager.h index 38494853ef7..3b28c5426fd 100644 --- a/packager/packager.h +++ b/packager/packager.h @@ -7,6 +7,7 @@ #ifndef PACKAGER_PACKAGER_H_ #define PACKAGER_PACKAGER_H_ +#include #include #include #include