Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to Load - Ubuntu 20.10 (gnome 3.38) #27

Open
cytech opened this issue Dec 30, 2020 · 5 comments
Open

Fails to Load - Ubuntu 20.10 (gnome 3.38) #27

cytech opened this issue Dec 30, 2020 · 5 comments

Comments

@cytech
Copy link

cytech commented Dec 30, 2020

πŸ—£οΈ Foreword

Thank for taking the time to fill this bug report fully. Without it we may not be able to fix the bug, and the issue may be closed without resolution.

πŸ‘» Brief Description

Extension Fails to Load - Ubuntu 20.10 (gnome 3.38)
error when installing - LG shows "meta is null"
journal shows:
JS ERROR: Extension lwsm@johannes.super-productivity.com: TypeError: meta is null
_createMenuItem@/home/user/.local/share/gnome-shell/extensions/lwsm@johannes.super-productivity.com/extension.js:184:15
_createMenu/<@/home/user/.local/share/gnome-shell/extensions/lwsm@johannes.super-productivity.com/extension.js:118:45
_createMenu@/home/user/.local/share/gnome-shell/extensions/lwsm@johannes.super-productivity.com/extension.js:117:19
_refresh@/home/user/.local/share/gnome-shell/extensions/lwsm@johannes.super-productivity.com/extension.js:293:10
_init@/home/user/.local/share/gnome-shell/extensions/lwsm@johannes.super-productivity.com/extension.js:34:10
enable@/home/user/.local/share/gnome-shell/extensions/lwsm@johannes.super-productivity.com/extension.js:326:12
_buildUi@/home/user/.local/share/gnome-shell/extensions/lwsm@johannes.super-productivity.com/extension.js:83:5
_init@/home/user/.local/share/gnome-shell/extensions/lwsm@johannes.super-productivity.com/extension.js:33:10
enable@/home/user/.local/share/gnome-shell/extensions/lwsm@johannes.super-productivity.com/extension.js:326:12

πŸ₯ž Action version

Latest installed thru gnome extensions

🎩 workflow configuration

Ubuntu 20.10 - Gnome 3.38

Steps To Reproduce

Steps to reproduce the behavior:

  1. install extension
  2. fails with error

lwsm is installed and works fine through the command line.

πŸš“ Expected behavior

load extension

βž• Additional context

possible issue: quick look showed that ST.boxlayout was deprecated in gnome 3.36, removed in 3.38
EDITED: st.boxlayout child meta deprecated/removed

@johannesjo
Copy link
Owner

Thank you very much for reporting and digging into this! Currently I am pretty busy with other stuff, but I will try to look into it at some point. Meanwhile PRs are welcome.

@cytech
Copy link
Author

cytech commented Dec 31, 2020

edit extension.js and change line 80:

let topBox = new St.BoxLayout();
to
let topBox = new St.BoxLayout({ x_expand: true, y_expand: true, });

allows the extension to load.

i don't know what else this might effect (no clue about gnome extension programming...)
it runs and works, although the dialog looks a little strange.

@johannesjo
Copy link
Owner

Thank you! Ill try this out next week.

@johannesjo
Copy link
Owner

I uploaded a new version with the fix you provided. Might take some time until they review it. Thank you very much! Please let me know if the issue persists for some reason.

@cytech
Copy link
Author

cytech commented Jan 6, 2021

πŸ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants