Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA SAST comparisons #48

Merged
merged 11 commits into from
Dec 10, 2024
Merged

GHA SAST comparisons #48

merged 11 commits into from
Dec 10, 2024

Conversation

johnbillion
Copy link
Owner

See #33

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Comment on lines +47 to +48
- name: Checkout code
uses: actions/checkout@v4

Check warning

Code scanning / zizmor

artipacked Warning

artipacked
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a known issue that Zizmor doesn't provide all of its information to the SARIF report: woodruffw/zizmor#66

Comment on lines +95 to +96
- name: Checkout repository
uses: actions/checkout@v4

Check warning

Code scanning / zizmor

artipacked Warning

artipacked
.github/workflows/lint.yml Fixed Show fixed Hide fixed
.github/workflows/lint.yml Fixed Show fixed Hide fixed
.github/workflows/lint.yml Fixed Show fixed Hide fixed
@johnbillion johnbillion marked this pull request as ready for review December 10, 2024 10:57
@johnbillion johnbillion merged commit 45e3051 into trunk Dec 10, 2024
7 checks passed
@johnbillion johnbillion deleted the sast-comparisons branch December 10, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants