-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API method to prepare Flash object for removing #111
Comments
Looks like IE would need something like this from SwfObject: |
Thanks for finding this. Could this be incorporated into MediaElement? As you don't use SwfObject internally and a user cannot determine what plugin was installed by MediaElement without hacking into, either you should use SwfObject for Flash or should provide a method for crossbrowser removal of the plugin element. |
I've spent several hours before fixing it myself. Symptoms were: Prior IE8:
IE8:
|
coagulant -- where did you apply your hack? i am loading inline videos with a colorbox & my debugger [IE8] is throwing a "node is null & not an object" error -- I think that this is due to the issue stated above, my player being unable to reinitialize in the colorbox. |
I was using colorbox jquery plugin, so I've put this code in |
I'm using the colorbox module for drupal & displaying my videos as inline content -- and they are turning up, but the controls don't work [hence the error being thrown] -- can't figure out how to bypass it. I'm confused; are you able to initialize the player properly on cbox_open? |
I'm creating |
I'd love to see an example of your implementation, if possible. I've been |
are you sure you placed it in the OnComplete callback? I feel like all the |
Sorry, I can't publish the code. |
I was thinking more of an idea as to how you built your URL. Most people can't publish their commissioned code, I understand. |
I'm finally getting around to adding this to the core project. Hopefully it'll show up in a minor release later this week. |
In 2.4.1, you can call the
|
This is awesome, John. Thank you. |
In the remove() function I was still getting an error in IE7 saying that "Object doesn't support this action" referencing the line:
Not sure if this was the best fix, but I fixed it by wrapping a try/catch around it like so:
|
When inserting and removing MediaElement dynamically, there is a problem in at least IE8 that Flash object continues to call ExternalInterface JS functions which in turn try to refer the corresponding DOM Element by its id. As soon as the DOM Element is detached, getElementById fails and IE8's ExternalInterface JS functions throw 'null is not an object' errors at each sendEvent from Flash.
So, there is a need to tell Flash object to stop calling JS functions. There should be some 'destroy' API method to fix this issue.
The text was updated successfully, but these errors were encountered: