[WIP] add analyze method SLIC to generate superpixels from image #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
===========================================
- Coverage 75.60% 28.97% -46.64%
===========================================
Files 4 5 +1
Lines 41 107 +66
===========================================
Hits 31 31
- Misses 10 76 +66
Continue to review full report at Codecov.
|
|
Hi @johnnychen94, If you are pleased, I will send a PR |
|
This is so great a news to me! Please do so! |
Add enforce connectivity feature in analyze method. The enforce connectivity implementation is based on [scikit-image](https://github.com/scikit-image/scikit-image/blob/7e4840bd9439d1dfb6beaf549998452c99f97fdd/skimage/segmentation/_slic.pyx#L240-L348). Because the original implementation uses 0-indexing, so I tried to translate into 1-indexing. Though so far there are no any problems about `unbounded error`, it is ought to conduct test because I think the implementation still have some problems in BFS part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Reference:
[1] Radhakrishna Achanta, Appu Shaji, Kevin Smith, Aurelien Lucchi, Pascal Fua, and Sabine Süsstrunk, SLIC Superpixels, EPFL Technical Report no. 149300, June 2010.
[2] The original C++ codes
[3] scikit-image's
slic