Fixed StackOverflow when adding exclusions #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a test to the |
| @@ -9,6 +10,7 @@ import org.gradle.api.specs.Specs | |||
| import org.gradle.api.tasks.util.PatternSet | |||
|
|
|||
| class DependencyFilter { | |||
| static Logger log = Logger.getLogger(DependencyFilter.class) | |||
There was a problem hiding this comment.
I'd prefer using the @Slf4j annotation on the class instead of declaring the logger this way.
| @@ -406,4 +406,43 @@ class FilteringSpec extends PluginSpecification { | |||
| and: | |||
| doesNotContain(output, ['a2.properties']) | |||
| } | |||
|
|
|||
| @Issue("SHADOW-69") | |||
| def "handle exclude with circular dependency"() { | |||
There was a problem hiding this comment.
Are there actual example of this out in the wild (i.e. circular dependencies in the POM files)?
Do you have an example of one. I'd like to look at it.
There was a problem hiding this comment.
I'm assuming you ran into one and that's what revealed this problem.
There was a problem hiding this comment.
Yes, the original bug had my stacktrace from real code in the wild. The dependencies where pretty messy, so it wasn't as clean as the simple unit test.
johnrengelman
added a commit
that referenced
this pull request
Jul 16, 2014
Fixed StackOverflow when adding exclusions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi John,
I opened a bug on this, then decided to take a whack at it...
Cheers,
-Brandon