-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opening with Chrome App Shortcuts causing infinite loop / not working #153
Comments
Hm not seeing the "Create application shortcut" menu item for google meet. There is a "Create shortcut" option but all it seems to do is to open up a normal tab in Chrome. I did find an "install" option when I tried https://excalidraw.com/ which I might be able to use. It installs an app (does not open a browser window). I will try using that first. |
No problem @johnste , this issue is actually solved with PR #160 that I submitted a while ago. Here's how I created an app shortcut for Google Meet: I then opened the Google Meet.app package and checked the Info.plist inside to get the app ID (mine was jhgifngagadhdmngcahhimadjfofillb). I then set up Finicky like so:
This worked perfectly for opening Google Meet links in the newly made Google Meet app! With this solution, I think this issue can be closed. |
Great to hear! I'm closing this issue, and I added a link to it in the wiki in case it might be useful for someone else. |
The solution that @skoshy suggested does not work for app shortcuts created with Brave. The correct app opens, but only for the url the app shortcut was created for, not the custom url that was passed in |
Hi @schiegl, I actually switched to using Brave (beta) too and I can confirm it does work with Brave. Here's what my config file looks like: const workBrowser = {
name: "com.brave.browser.beta",
profile: "Profile 1"
};
const googleMeetApp = {
browser: ({ urlString }) => ({
...workBrowser,
args: [
'--app-id=dbpkegghbgplfeaapbejbnfpbgnbjedf', // substitute with your app's app ID
`--app-launch-url-for-shortcuts-menu-item=${ urlString }`,
],
}),
};
module.exports = {
defaultBrowser: "com.brave.browser.beta",
handlers: [
{
match: finicky.matchHostnames(["meet.google.com"]),
...googleMeetApp,
},
{
// Open any link clicked in Slack in my work browser
match: ({ opener }) =>
opener.bundleId === "com.tinyspeck.slackmacgap",
browser: workBrowser
},
]
} This config works great for me for Google Meet; we have a pinned Meet link to a specific meeting in our Slack group, and clicking it opens that exact meeting in the Google Meet Brave app. Other Google Meet links open appropriately as well. |
What a coincidence that you switched to Brave @skoshy! Using "Profile 1" seems to work for Google Meet, but not for Jira. Jira opens in a new tab instead of the app shortcut window (which also opens but remains blank). Also, the profile the shortcut was created in is not named "Profile 1". Not sure why "Profile 1" works? Lastly, for some reason opening links through finicky takes much longer than opening shortcut apps with the system launcher. Instead of ~1s, it takes 5s. This is not due to page loading, as opening the webpage in a tab also just takes ~1s. Does this also happen to you? |
So the profile doesn't refer to the profile name, it refers to the profile folder. For me, my work profile in Brave is named You can find all the profile directories in The default profile is just called
Hmm, only advice for this is to check if the right profile directory is being used, and the correct
For me, it adds maybe 1s delay, definitely not 5s though. That's an inherent problem with Finicky though I believe. |
The app-id is correct as the correct app shortcut opens. It is however blank. Given that the other apps work, maybe I matched the url wrong.
That is unfortunate. |
A short note, in chrome (with multiple profiles), specifying the profile caused this not to work (it'd open a blank chrome tab). Either commenting out that line( |
Hello guys, if the shortcut app is already open, it opens another instance of the shortcut app for you too? |
If I try specifying a direct path to a Chrome App Shortcut (generated through Chrome Menu -> More Tools -> Create application shortcut), it causes an infinite loop of opening the window and doesn't actually go to the correct URL within the app as well.
Google Meet is a good example; if you have a Chrome App of https://meet.google.com and try clicking a Google Meet link from somewhere else, this behavior occurs.
Here's my config:
The text was updated successfully, but these errors were encountered: